rt: fix queue regression #2362
Merged
rt: fix queue regression #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new queue uses `u8` to track offsets. Cursors are expected to wrap. An operation was performed with `+` instead of `wrapping_add`. This was not _obviously_ issue before as it is difficult to wrap a `usize` on 64bit platforms, but wrapping a `u8` is trivial. The fix is to use `wrapping_add` instead of `+`. A new test is added that catches the issue. Fixes #2361
stuhood
added a commit
to twitter/pants
that referenced
this pull request
Apr 2, 2020
# Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests] # No JVM changes made.
jonhoo
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new queue uses
u8to track offsets. Cursors are expected to wrap.An operation was performed with
+instead ofwrapping_add. This wasnot obviously issue before as it is difficult to wrap a
usizeon64bit platforms, but wrapping a
u8is trivial.The fix is to use
wrapping_addinstead of+. A new test is addedthat catches the issue.
Fixes #2361