Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce pin related unsafe code #2613

Merged
merged 2 commits into from
Jun 12, 2020
Merged

Reduce pin related unsafe code #2613

merged 2 commits into from
Jun 12, 2020

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jun 12, 2020

Motivation

Solution

@taiki-e
Copy link
Member Author

taiki-e commented Jun 12, 2020

Hm, CI seems to fail due to cargo bug: rust-lang/cargo#8351

Darksonn
Darksonn approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a read through, and I can't spot any issues. 👍

@Darksonn Darksonn added A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. labels Jun 12, 2020
@taiki-e taiki-e mentioned this pull request Jun 12, 2020
Merged
@taiki-e taiki-e merged commit 6b6e760 into tokio-rs:master Jun 12, 2020
@taiki-e taiki-e deleted the safe-pin branch June 12, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taiki-e @Darksonn