io: remove poll_{read,write}_buf from traits #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
approved these changes
Sep 24, 2020
tokio-util/src/io/mod.rs
Outdated
| ready!(io.poll_read(cx, &mut b))?; | ||
| let n = b.filled().len(); | ||
|
|
||
| // Safety: we can assume `n` bytes were read, since they are in`filled`. |
There was a problem hiding this comment.
I believe this is this footgun: #2827
carllerche
commented
Sep 24, 2020
| let n = b.filled().len(); | ||
|
|
||
| // Safety: we can assume `n` bytes were read, since they are in`filled`. | ||
| assert_eq!(orig, b.filled().as_ptr()); |
There was a problem hiding this comment.
@seanmonstar does this fix the footgun?
Darksonn
added
A-tokio
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions have object safety issues. It also has been decided to
avoid vectored operations on the I/O traits. A later PR will bring back
vectored operations on specific types that support them.
Refs: #2879, #2716