Fix fill_buf by not calling poll_fill_buf twice #4084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should some kind of regression test be added here? |
|
I don't think it's particularly necessary here, but I can add one. |
carllerche
approved these changes
Aug 31, 2021
Darksonn
added a commit
that referenced
this pull request
Aug 31, 2021
hawkw
approved these changes
Aug 31, 2021
| use tokio_test::assert_ok; | ||
|
|
||
| #[tokio::test] | ||
| async fn fill_buf_file() { |
There was a problem hiding this comment.
take it or leave it: maybe worth a comment summarizing the bug this is a regression test for (and a link to the original issue?)
There was a problem hiding this comment.
I don't really feel like waiting for CI over again, since I am making a release immediately after merging this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some IO resources which hit the panic when calling
poll_fill_buftwice, e.g. aBufReader<File>will do this when you are at EOF.A safe alternative is to check for empty slices and handle those in a special way, but I prefer this as it is a more robust solution.
Fixes: #4085