net: add poll_{recv,send}_ready methods to udp/uds_datagram #4131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
force-pushed
the
baloo/udp-poll_ready
branch
from
8f224af to
a7a8325
Compare
|
Please check the rustfmt CI job. |
baloo
force-pushed
the
baloo/udp-poll_ready
branch
from
a7a8325 to
d67a388
Compare
Darksonn
reviewed
Sep 23, 2021
tokio/src/net/udp.rs
Outdated
| /// stream becomes ready for writing, `Waker::wake` will be called on the | ||
| /// waker. | ||
| /// | ||
| /// Note that on multiple calls to `poll_write_ready` or `poll_write`, only |
There was a problem hiding this comment.
There is no poll_write method on UdpSocket. This should instead mention poll_send and poll_send_to.
tokio/src/net/udp.rs
Outdated
Comment on lines
673
to
674
| /// Note that on multiple calls to `poll_read_ready`, `poll_read` or | ||
| /// `poll_peek`, only the `Waker` from the `Context` passed to the most |
baloo
force-pushed
the
baloo/udp-poll_ready
branch
from
d67a388 to
4a19b23
Compare
|
shouldn't we rename the two methods poll_recv_ready and poll_send_ready? |
|
Sure, that makes sense to me. |
|
I just noticed that the methods are also missing on |
baloo
changed the title
baloo
force-pushed
the
baloo/udp-poll_ready
branch
from
4a19b23 to
bf096a9
Compare
similar to unix and tcp sockets, this commits brings `poll_read_ready` and `poll_write_ready` methods. Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
baloo
force-pushed
the
baloo/udp-poll_ready
branch
from
bf096a9 to
5291bc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
UDP was missing
poll_read_readyandpoll_write_readymethodsUDS datagram was missing them as well
Solution
similar to unix and tcp sockets, this brings poll_read_ready and
poll_write_ready methods to udp and UDS Datagram