Remove error case from the infallible DelayQueue::poll_elapsed #4241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
force-pushed
the
infallible-poll-elapsed
branch
2 times, most recently
from
ce53a53
to
675c262
Compare
Ralith
force-pushed
the
infallible-poll-elapsed
branch
from
675c262
to
c6d2e3a
Compare
Darksonn
added
A-tokio-util
|
This is a breaking change, but we also have two other pending changes that are breaking, so it might be time to do a breaking tokio-util release soon. |
tobz
added
the
S-breaking-change
tobz
approved these changes
Feb 8, 2022
|
Making sure the CI passes after resolving the merge conflict before actually merging. |
Signed-off-by: Toby Lawrence <toby@nuclearfurnace.com>
|
Thanks for sorting out the conflicts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It is unclear why
DelayQueue::poll_elapsedmight fail, and therefore how a caller should respond to a failure.Solution
As the method cannot, in fact, fail, removing the possibility of returning an error avoids confusion for callers.