RunError and few more error types implements Error #501
Conversation
tokio-current-thread/src/lib.rs
Outdated
| fn description(&self) -> &str { | ||
| "Block error" | ||
| } | ||
| fn cause(&self) -> Option<&Error> { |
There was a problem hiding this comment.
Do you really need to provide these cause functions?
There was a problem hiding this comment.
Ah, no, I don't (I thought both were mandatory, but they are both provided in fact).
I'd still like to keep the one in the wrapper RunError ‒ as it delegates to the inner error, this is more robust for the future if the inner error might change the implementation.
|
Use special github syntax: |
This allows them to be used with things like `failure`.
|
Um… I guess this change should not be able to create data races, right? |
| self.inner.description() | ||
| } | ||
| fn cause(&self) -> Option<&Error> { | ||
| self.inner.cause() |
There was a problem hiding this comment.
Are you sure this should be self.inner.cause() and not just self.inner?
There was a problem hiding this comment.
Using self.inner.cause() is the correct strategy here.
There was a problem hiding this comment.
I wasn't sure. But I felt this was actually the same error, just dressed in other clothes than one error causing another ‒ it wasn't like „Permission denied → Can't load configuration“ relation.
This allows them to be used with things like
failure.This is for #491.
The descriptions are a bit unhelpful I fear, but that's because I don't know what the error means and when it can actually happen. The doc's don't say and I gave up tracking it after few layers of things calling other things and translating errors around. Nevertheless, I think this is still a step forward.