Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare Tokio v1.30.0 release #5917

Merged
merged 15 commits into from
Aug 9, 2023

Conversation

bcardarella
Copy link
Contributor

@bcardarella bcardarella commented Aug 7, 2023

As requested by @Darksonn in #5887

First time doing this for this project so please let me know if if I need to correct something. I went through all of the commits after the v1.29.1 release on June 29 and tried to sort them into the CHANGELOG buckets that made sense but may have misplaced some.

1.30.0 (August 9, 2023)

This release bumps the MSRV of Tokio to 1.63. (#5887)

Changed

  • tokio: reduce LLVM code generation (#5859)
  • io: support --cfg mio_unsupported_force_poll_poll flag (#5881)
  • sync: make const_new methods always available (#5885)
  • sync: avoid false sharing in mpsc channel (#5829)
  • rt: pop at least one task from inject queue (#5908)

Added

  • sync: add broadcast::Sender::new (#5824)
  • net: implement UCred for espidf (#5868)
  • fs: add File::options() (#5869)
  • time: implement extra reset variants for Interval (#5878)
  • process: add {ChildStd*}::into_owned_{fd, handle} (#5899)

Removed

  • tokio: removed unused tokio_* cfgs (#5890)
  • remove build script to speed up compilation (#5887)

Documented

  • sync: mention lagging in docs for broadcast::send (#5820)
  • runtime: expand on sharing runtime docs (#5858)
  • io: use vec in example for AsyncReadExt::read_exact (#5863)
  • time: mark Sleep as !Unpin in docs (#5916)
  • process: fix raw_arg not showing up in docs (#5865)

Unstable

  • rt: add runtime ID (#5864)
  • rt: initial implementation of new threaded runtime (#5823)

tokio/CHANGELOG.md Outdated Show resolved Hide resolved
tokio/CHANGELOG.md Outdated Show resolved Hide resolved
tokio/CHANGELOG.md Outdated Show resolved Hide resolved
tokio/CHANGELOG.md Show resolved Hide resolved
@bcardarella
Copy link
Contributor Author

Updated to resolve @NobodyXu's change requests

Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Several changes in the changelog seem to be unrelated to tokio crate. (FYI, the directory-level commit history shows only changes related to tokio crate: https://github.com/tokio-rs/tokio/commits/master/tokio)

tokio/CHANGELOG.md Outdated Show resolved Hide resolved
tokio/CHANGELOG.md Outdated Show resolved Hide resolved
tokio/CHANGELOG.md Outdated Show resolved Hide resolved
tokio/CHANGELOG.md Outdated Show resolved Hide resolved
tokio/CHANGELOG.md Outdated Show resolved Hide resolved
tokio/CHANGELOG.md Outdated Show resolved Hide resolved
tokio/CHANGELOG.md Outdated Show resolved Hide resolved
tokio/CHANGELOG.md Outdated Show resolved Hide resolved
tokio/CHANGELOG.md Outdated Show resolved Hide resolved
tokio/CHANGELOG.md Outdated Show resolved Hide resolved
@bcardarella
Copy link
Contributor Author

@taiki-e made your requested changes

tokio/CHANGELOG.md Outdated Show resolved Hide resolved
@Darksonn Darksonn added the A-tokio Area: The main tokio crate label Aug 8, 2023
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to prepare this PR!

tokio/CHANGELOG.md Outdated Show resolved Hide resolved
tokio/CHANGELOG.md Outdated Show resolved Hide resolved
tokio/CHANGELOG.md Outdated Show resolved Hide resolved
Comment on lines 36 to 37
- rt: add runtime ID (#5864)
- rt: initial implementation of new threaded runtime (#5823)
Copy link
Contributor

@Darksonn Darksonn Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please turn all of the changelog lines into links. Here's an example of how it should look with two of the links:

Suggested change
- rt: add runtime ID (#5864)
- rt: initial implementation of new threaded runtime (#5823)
- rt: add runtime ID ([#5864])
- rt: initial implementation of new threaded runtime ([#5823])
[#5823]: https://github.com/tokio-rs/tokio/pull/5823
[#5864]: https://github.com/tokio-rs/tokio/pull/5864

Note the two changes:

  • Square brackets added around PR number in the commit message.
  • Links added at the bottom, in sorted order.

@bcardarella
Copy link
Contributor Author

@Darksonn done!

tokio/CHANGELOG.md Outdated Show resolved Hide resolved
tokio/CHANGELOG.md Outdated Show resolved Hide resolved
@bcardarella
Copy link
Contributor Author

@taiki-e done!

tokio/CHANGELOG.md Outdated Show resolved Hide resolved
@bcardarella
Copy link
Contributor Author

@taiki-e thank you! Sorry it took a few passes to get it where you all wanted, thanks for holding my hand 🎉

@bcardarella
Copy link
Contributor Author

What are the next steps? Do I have to do anything else?

Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the changelog is ready, you just need to wait for me to get to a laptop. I will merge it at the same time as when I publish it.


[#5887]: https://github.com/tokio-rs/tokio/pull/5887
[#5859]: https://github.com/tokio-rs/tokio/pull/5859
[#5859]: https://github.com/tokio-rs/tokio/pull/5881
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link appears twice. Please double check the links. We usually sort them to make them easier to see.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Darksonn done, I did originally consider sorting but I looked at a few prior entries and they weren't sorted but I agree it is best

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it depends on who wrote it. I always sort them.

@bcardarella
Copy link
Contributor Author

I'm not sure why CI keeps failing, is that something I need to address?

@Darksonn
Copy link
Contributor

Darksonn commented Aug 9, 2023

No. I opened an issue #5920 and I will restart ci.

@bcardarella
Copy link
Contributor Author

@Darksonn sounds good, if any other changes are necessary for this PR I'll be here ready to fix!

Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this. I'll merge it later when I get to a laptop.

Please double check whether any new things have been merged in the meantime.

@bcardarella
Copy link
Contributor Author

will do!

@bcardarella
Copy link
Contributor Author

@Darksonn there are two commits that have happened since I opened this PR. They are:

I asume the ci one shouldn't be included as indicated from prior comments. Is #5899 OK to include?

@Darksonn Darksonn enabled auto-merge (squash) August 9, 2023 14:53
@bcardarella
Copy link
Contributor Author

@Darksonn nm, looks like you took care of it

@Darksonn
Copy link
Contributor

Darksonn commented Aug 9, 2023

Yeah, thanks for taking the time to prepare this PR. It will be published shortly.

@Darksonn Darksonn merged commit 4c220af into tokio-rs:master Aug 9, 2023
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants