Reduce LLVM code generation #5859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current changes look good to me. Since this is marked as a draft, is there anything else you would like to change? |
hawkw
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
this looks good to me!
i wonder if there are other places in the codebase where a function is monomorphized over multiple type parameters but only needs to be monomorphized over one of them. of course, code that's generated per-future is almost certainly the biggest culprit in terms of build time...
|
It's now ready to merge |
Darksonn
approved these changes
Jul 14, 2023
Co-authored-by: Alice Ryhl <aliceryhl@google.com>
It decreases total LLVM lines in Lemmy by 8.5% |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the amount of LLVM code generated, which is helpful for compilation speed.
Motivation
A big portion of LLVM code generation for Lemmy server is caused by a few Tokio functions: cargo llvm-lines output
It would be helpful to reduce this because it contributes to Lemmy's extremely slow compilation.
Solution
Split parts of functions into separate functions without unneeded generic parameters: https://nnethercote.github.io/perf-book/compile-times.html#llvm-ir