Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] Raise the number of maximum fields #1566

Closed
LukeMathWalker opened this issue Sep 15, 2021 · 0 comments · Fixed by #2508
Closed

[Feature request] Raise the number of maximum fields #1566

LukeMathWalker opened this issue Sep 15, 2021 · 0 comments · Fixed by #2508

Comments

@LukeMathWalker
Copy link
Contributor

LukeMathWalker commented Sep 15, 2021 •
edited

Feature Request

Crates

Motivation

At the moment, 32 is the maximum number of fields that can be attached to a span.
While it might seem a lot, at TrueLayer we bumped into this limit several times: a complex business operation will involve several domain-relevant identifiers as well as multiple "technical" fields (e.g. OpenTelemetry required fields according to semantic conventions).

Proposal

I see two main options:

  • Make it configurable via a feature flag, similarly to what diesel does for the maximum number of columns. Those who need the feature pay the cost for it, all other users are not impacted;
  • Remove the limit entirely, using a growable data structure (which would perhaps unlock Add support for recording dynamic fields #1343 as well?), which I imagine would end up affecting performance by requiring more allocations?

Alternatives

Keep it as it? 🤷🏻‍♂️
@eopb eopb mentioned this issue Mar 14, 2023
Merged
hawkw pushed a commit that referenced this issue Sep 5, 2023
@eopb
core: allow ValueSets of any length (#2508)
1c855ae 
## Motivation

Fixes: #1566

## Solution

This change removes the maximum of 32 fields limitation using const
generics.

Having this arbitrary restriction in place to prevent stack overflows
feels a little misplaced to me since stack size varies between
environments.
davidbarsky pushed a commit that referenced this issue Sep 26, 2023
@eopb @davidbarsky
core: allow ValueSets of any length (#2508)
407d88d 
## Motivation

Fixes: #1566

## Solution

This change removes the maximum of 32 fields limitation using const
generics.

Having this arbitrary restriction in place to prevent stack overflows
feels a little misplaced to me since stack size varies between
environments.
davidbarsky pushed a commit that referenced this issue Sep 27, 2023
@eopb @davidbarsky
core: allow ValueSets of any length (#2508)
6fb787d 
## Motivation

Fixes: #1566

## Solution

This change removes the maximum of 32 fields limitation using const
generics.

Having this arbitrary restriction in place to prevent stack overflows
feels a little misplaced to me since stack size varies between
environments.
davidbarsky pushed a commit that referenced this issue Sep 27, 2023
@eopb @davidbarsky
core: allow ValueSets of any length (#2508)
10713e7 
## Motivation

Fixes: #1566

## Solution

This change removes the maximum of 32 fields limitation using const
generics.

Having this arbitrary restriction in place to prevent stack overflows
feels a little misplaced to me since stack size varies between
environments.
davidbarsky pushed a commit that referenced this issue Sep 27, 2023
@eopb @davidbarsky
core: allow ValueSets of any length (#2508)
d179ac8 
## Motivation

Fixes: #1566

## Solution

This change removes the maximum of 32 fields limitation using const
generics.

Having this arbitrary restriction in place to prevent stack overflows
feels a little misplaced to me since stack size varies between
environments.
davidbarsky pushed a commit that referenced this issue Sep 27, 2023
@eopb @davidbarsky
core: allow ValueSets of any length (#2508)
3e1f23e 
## Motivation

Fixes: #1566

## Solution

This change removes the maximum of 32 fields limitation using const
generics.

Having this arbitrary restriction in place to prevent stack overflows
feels a little misplaced to me since stack size varies between
environments.
davidbarsky pushed a commit that referenced this issue Sep 29, 2023
@eopb @davidbarsky
core: allow ValueSets of any length (#2508)
b0e3c71 
## Motivation

Fixes: #1566

## Solution

This change removes the maximum of 32 fields limitation using const
generics.

Having this arbitrary restriction in place to prevent stack overflows
feels a little misplaced to me since stack size varies between
environments.
hawkw pushed a commit that referenced this issue Oct 1, 2023
@eopb @hawkw
core: allow ValueSets of any length (#2508)
1771128 
## Motivation

Fixes: #1566

## Solution

This change removes the maximum of 32 fields limitation using const
generics.

Having this arbitrary restriction in place to prevent stack overflows
feels a little misplaced to me since stack size varies between
environments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow value_sets of any length eopb/tracing
1 participant
@LukeMathWalker