Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macros: fix the tracing-macros crate not compiling #1000

Merged
merged 1 commit into from
Sep 29, 2020

Commits on Sep 29, 2020

  1. macros: fix the tracing-macros crate not compiling

    The `tracing-macros` crate doesn't currently compile with the latest
    `tracing` release, because it uses internal private APIs. We need to fix
    this so CI isn't broken.
    
    I changed the `dbg!` macro so it no longer uses internal APIs. Ideally,
    we would implement `dbg!` using the support for string-literal field
    names that was recently added to `tracing`, but I couldn't actually get
    it to work --- I think the `event!` macros may not handle string literal
    field names properly (we only test them with the `span!` macros >_>).
    Will try to fix that later, but for now, this fixes CI and I don't think
    anyone actually uses the experimental, unreleased `tracing-macros` crate.
    
    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    hawkw committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    786c713 View commit details
    Browse the repository at this point in the history