-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: rename Subscriber to Collect #1015
Merged
Merged
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
91c9c08
core: rename Subscriber to Collector
davidbarsky 251a2ae
fmt
davidbarsky 9025172
fix test
davidbarsky a7203be
Rename stuff in subscriber; fix doc links
davidbarsky f16594b
subscriber tests
davidbarsky 8b6509a
fmt
davidbarsky 8ad2232
fixup more docs
davidbarsky 1623234
fix tests
davidbarsky 4d438d9
fix tracing-error
davidbarsky 381c2fe
fix clippy warnings for open-telemetry
davidbarsky 2eb1370
more test fixes
davidbarsky e854ba3
whoops
davidbarsky 0324a8d
lol wtf
davidbarsky 592d38f
fix issues
davidbarsky 050f845
fmt
davidbarsky 2573d8d
Merge branch 'davidbarsky/rename-subscriber'
davidbarsky f7a2350
Merge branch 'master' into davidbarsky/rename-subscriber
davidbarsky 796ffed
fuck
davidbarsky 4739de9
fuuuuuuuuck
davidbarsky fb4152c
ahhhh
davidbarsky 6cfb65b
docs
davidbarsky abe7718
add back dropped `alloc` feature
davidbarsky 341a30a
fix tests
davidbarsky 38fedc0
Update README.md
davidbarsky 2bce4c2
Update examples/README.md
davidbarsky 174a131
Update tracing-error/src/layer.rs
davidbarsky c5cc009
Update examples/examples/toggle-layers.rs
davidbarsky 1f3d7ad
Merge remote-tracking branch 'origin/master' into davidbarsky/rename-…
davidbarsky bd9fbc1
renamed to verbs
davidbarsky 9c6dfbc
fix reload
davidbarsky 945fe38
update `collect`
davidbarsky 5073c9d
rename tracing/collect
davidbarsky 93bf957
fix docs in core
davidbarsky 68286a4
fixing shit
davidbarsky abddfec
whoops
davidbarsky 5b271a3
Update tracing-core/src/metadata.rs
davidbarsky 5f10616
Update tracing-futures/src/lib.rs
davidbarsky 4a710de
Update tracing-futures/src/lib.rs
davidbarsky 4eb35c6
Update tracing-futures/src/lib.rs
davidbarsky 84560da
Update tracing-futures/src/lib.rs
davidbarsky f95b3fb
Apply suggestions from code review
davidbarsky 99b0627
Update tracing-core/src/metadata.rs
davidbarsky 509dbdd
Update tracing-core/src/metadata.rs
davidbarsky 58146ca
Apply suggestions from code review
davidbarsky 942219f
Apply suggestions from code review
davidbarsky 1bc9c7e
whoops
davidbarsky 88382e3
Rename tracing/dispatcher to tracing/dispatch
davidbarsky 2c5a2f9
rename dispatch in core
davidbarsky 91aa806
huh?
davidbarsky 15249e2
less weird shit now!
davidbarsky 1a55a53
some more fixes
davidbarsky 535f90c
Merge remote-tracking branch 'origin/master' into davidbarsky/rename-…
davidbarsky d60df87
renaming shit
davidbarsky 645d561
more renaming!
davidbarsky 87517fa
doc link fixes
davidbarsky 9a11e29
Apply suggestions from code review
hawkw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we may want to update this description to focus on the
Subscriber
trait a bit more.