Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracing: readme cleanup #142

Merged
merged 4 commits into from
Jul 3, 2019
Merged

tracing: readme cleanup #142

merged 4 commits into from
Jul 3, 2019

Conversation

hawkw
Copy link
Member

@hawkw hawkw commented Jul 3, 2019

This branch cleans up the tracing readme, including fixing
links that incorrectly pointed to tracing-core, and adds a
link to tracing-timing in related crates.

Signed-off-by: Eliza Weisman eliza@buoyant.io

hawkw added 3 commits July 3, 2019 10:55
@hawkw
tracing: link tracing-timing in related crates
7abd851 
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw
tracing: readme updates
786f90a 
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw
tracing: fix readme links to tracing-core
ca71f32 
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw hawkw added kind/docs crate/tracing Related to the `tracing` crate labels Jul 3, 2019
@hawkw hawkw requested review from jonhoo and LucioFranco July 3, 2019 18:00
@hawkw hawkw self-assigned this Jul 3, 2019
This was referenced Jul 3, 2019
Closed
Merged
jonhoo
jonhoo reviewed Jul 3, 2019
View reviewed changes
tracing/README.md Outdated Show resolved Hide resolved
tracing/README.md Outdated Show resolved Hide resolved
tracing/README.md Outdated Show resolved Hide resolved
tracing/src/lib.rs Outdated Show resolved Hide resolved
@hawkw
review feedback
8a3a38c 
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw
Copy link
Member Author

hawkw commented Jul 3, 2019

@jonhoo thanks for the notes! I've made all your suggested changes in 8a3a38c

@jonhoo
Copy link
Sponsor Contributor

jonhoo commented Jul 3, 2019

LGTM 👍

@hawkw hawkw merged commit 1a1002a into master Jul 3, 2019
@hawkw hawkw deleted the eliza/readme-cleanup branch July 3, 2019 20:27
hawkw added a commit that referenced this pull request Jul 3, 2019
@hawkw
chore: remove remaining references to tracing-nursery (#144)
872d893 
This branch removes all remaining references to the
non-existent `tracing-nursery` repository that weren't
removed in #142 and #141.

Closes #125 

* chore: remove nursery mentions from .github
* core: remove references to `tracing-nursery`

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhoo jonhoo jonhoo approved these changes

@davidbarsky davidbarsky davidbarsky approved these changes

@LucioFranco LucioFranco Awaiting requested review from LucioFranco

Assignees

@hawkw hawkw

Labels
crate/tracing Related to the `tracing` crate kind/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hawkw @jonhoo @davidbarsky