Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify span traversal #1431

Merged
merged 33 commits into from
Jun 22, 2021
Merged

Unify span traversal #1431

merged 33 commits into from
Jun 22, 2021

Commits on Jun 9, 2021

  1. Implement SpanRef::scope and SpanRef::scope.from_root iterators 

    See tokio-rs#1429
    @nightkr
    nightkr committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    0e45e83 View commit details
    Browse the repository at this point in the history

  2. Implement smallvec optimization for SpanScopeFromRoot

    @nightkr
    nightkr committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    5c379fb View commit details
    Browse the repository at this point in the history

  3. Replace legacy span iterator implementations with SpanRef::scope

    @nightkr
    nightkr committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    cd8148f View commit details
    Browse the repository at this point in the history

  4. Migrate tracing-subscriber to SpanRef::scope

    @nightkr
    nightkr committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    84afb38 View commit details
    Browse the repository at this point in the history

  5. Migrate layer crates to use SpanRef::scope

    @nightkr
    nightkr committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    9ec8130 View commit details
    Browse the repository at this point in the history

  6. Reverted tracing-error span iteration order 

    Oops
    @nightkr
    nightkr committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    d12cd51 View commit details
    Browse the repository at this point in the history

  7. Fixed flipped scope order in tracing-journald

    @nightkr
    nightkr committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    4d0fd19 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2021

  1. Bump tracing-subscriber version

    @nightkr
    nightkr committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    8d162d4 View commit details
    Browse the repository at this point in the history

  2. Update tracing-subscriber/src/fmt/fmt_layer.rs 

    Co-authored-by: Eliza Weisman <eliza@buoyant.io>
    @nightkr @hawkw
    nightkr and hawkw committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    cafb3a6 View commit details
    Browse the repository at this point in the history

  3. Correct note about Scope::from_root allocating

    @nightkr
    nightkr committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    b31e9d7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/unified-span-iteration' of github.com:appva/tra… 

    …cing into feature/unified-span-iteration
    @nightkr
    nightkr committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    0d1294d View commit details
    Browse the repository at this point in the history

  5. Add example for Scope::from_root

    @nightkr
    nightkr committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    5bad9d4 View commit details
    Browse the repository at this point in the history

  6. Mention Scope::from_root in SpanRef::scope

    @nightkr
    nightkr committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    72d6a9e View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. Turn layer::Scope back into a newtype

    @nightkr
    nightkr committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    681f7cb View commit details
    Browse the repository at this point in the history

  2. Add usage examples for SpanRef::scope

    @nightkr
    nightkr committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    82004f9 View commit details
    Browse the repository at this point in the history

  3. Update tracing-subscriber/src/registry/mod.rs 

    Co-authored-by: Eliza Weisman <eliza@buoyant.io>
    @nightkr @hawkw
    nightkr and hawkw committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    3e94ef6 View commit details
    Browse the repository at this point in the history

  4. Update tracing-subscriber/src/registry/mod.rs 

    Co-authored-by: Eliza Weisman <eliza@buoyant.io>
    @nightkr @hawkw
    nightkr and hawkw committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    1fb6ccd View commit details
    Browse the repository at this point in the history

  5. Simplify tracing-flame span iteration

    @nightkr
    nightkr committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    1a47484 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'feature/unified-span-iteration' of github.com:appva/tra… 

    …cing into feature/unified-span-iteration
    @nightkr
    nightkr committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    3c9386f View commit details
    Browse the repository at this point in the history

  7. Only build layer::Scope Iterator when registry is enabled

    @nightkr
    nightkr committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    5319df0 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2021

  1. Clarify and correct deprecation messages a bit

    @nightkr
    nightkr committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    92fedf9 View commit details
    Browse the repository at this point in the history

  2. Convert registry::{Parents, FromRoot} to newtypes as well

    @nightkr
    nightkr committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    6b077f4 View commit details
    Browse the repository at this point in the history

  3. Add Context::span_scope helper, improve documentation on why `Conte… 

    …xt::scope`

is harmful
    @nightkr
    nightkr committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    6b4d4b3 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Eliza Weisman <eliza@buoyant.io>
    @nightkr @hawkw
    nightkr and hawkw committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    00fb1dc View commit details
    Browse the repository at this point in the history

  2. Show SpanRef::scope examples in an actual Layer

    @nightkr
    nightkr committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    235ab89 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/v0.1.x' into feature/unified-spa… 

    …n-iteration
    @nightkr
    nightkr committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    3c917b2 View commit details
    Browse the repository at this point in the history

  4. Fix Clippy warnings 

    None of these are really related to this PR, but Clippy was unhappy...
    @nightkr
    nightkr committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    cb41242 View commit details
    Browse the repository at this point in the history

  5. Fix the rest of the Clippy warnings 

    Because GitHub still wasn't happy.
    @nightkr
    nightkr committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    2b093df View commit details
    Browse the repository at this point in the history

  6. Rustfmt

    @nightkr
    nightkr committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    8774877 View commit details
    Browse the repository at this point in the history

  7. Fix broken doctests on MSRV (1.42.0)

    @nightkr
    nightkr committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    a9eb2d5 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2021

  1. Move SpanRef::scope assertions into real tests 

    Rather than keeping them merged with the doctests
    @nightkr
    nightkr committed Jun 20, 2021
    Configuration menu
    Copy the full SHA
    b651701 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Eliza Weisman <eliza@buoyant.io>
    @nightkr @hawkw
    nightkr and hawkw committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    7ef5c0a View commit details
    Browse the repository at this point in the history

  2. Use subscriber guard consistently in scope tests

    @nightkr
    nightkr committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    1f32622 View commit details
    Browse the repository at this point in the history