Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: make Level and LevelFilter Hash #1456

Merged
merged 2 commits into from
Aug 6, 2021

Conversation

dvdplm
Copy link
Contributor

@dvdplm dvdplm commented Jul 2, 2021

Fixes: #1376

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I see no real reason why these shouldn't be Hash, thanks!

@hawkw hawkw merged commit 6ad45ef into tokio-rs:master Aug 6, 2021
hawkw added a commit that referenced this pull request Aug 17, 2021
Fixes: #1376

Co-authored-by: Eliza Weisman <eliza@buoyant.io>
hawkw added a commit that referenced this pull request Aug 17, 2021
Fixes: #1376

Co-authored-by: Eliza Weisman <eliza@buoyant.io>
hawkw added a commit that referenced this pull request Aug 17, 2021
# 0.1.19 (August 17, 2021)
### Added

- `Level::as_str` ([#1413])
- `Hash` implementation for `Level` and `LevelFilter` ([#1456])
- `Value` implementation for `&mut T where T: Value` ([#1385])
- Multiple documentation fixes and improvements ([#1435], [#1446])

Thanks to @Folyd, @teozkr, and @dvdplm for contributing to this release!

[#1413]: #1413
[#1456]: #1456
[#1385]: #1385
[#1435]: #1435
[#1446]: #1446

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw added a commit that referenced this pull request Aug 17, 2021
# 0.1.19 (August 17, 2021)
### Added

- `Level::as_str` ([#1413])
- `Hash` implementation for `Level` and `LevelFilter` ([#1456])
- `Value` implementation for `&mut T where T: Value` ([#1385])
- Multiple documentation fixes and improvements ([#1435], [#1446])

Thanks to @Folyd, @teozkr, and @dvdplm for contributing to this release!

[#1413]: #1413
[#1456]: #1456
[#1385]: #1385
[#1435]: #1435
[#1446]: #1446

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw added a commit that referenced this pull request Aug 17, 2021
# 0.1.19 (August 17, 2021)
### Added

- `Level::as_str` ([#1413])
- `Hash` implementation for `Level` and `LevelFilter` ([#1456])
- `Value` implementation for `&mut T where T: Value` ([#1385])
- Multiple documentation fixes and improvements ([#1435], [#1446])

Thanks to @Folyd, @teozkr, and @dvdplm for contributing to this release!

[#1413]: #1413
[#1456]: #1456
[#1385]: #1385
[#1435]: #1435
[#1446]: #1446

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
# 0.1.19 (August 17, 2021)
### Added

- `Level::as_str` ([tokio-rs#1413])
- `Hash` implementation for `Level` and `LevelFilter` ([tokio-rs#1456])
- `Value` implementation for `&mut T where T: Value` ([tokio-rs#1385])
- Multiple documentation fixes and improvements ([tokio-rs#1435], [tokio-rs#1446])

Thanks to @Folyd, @teozkr, and @dvdplm for contributing to this release!

[tokio-rs#1413]: tokio-rs#1413
[tokio-rs#1456]: tokio-rs#1456
[tokio-rs#1385]: tokio-rs#1385
[tokio-rs#1435]: tokio-rs#1435
[tokio-rs#1446]: tokio-rs#1446

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Level is not Hash – can I make it so?
2 participants