Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attributes: prepare to release v0.1.16 #1560

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Conversation

hawkw
Copy link
Member

@hawkw hawkw commented Sep 13, 2021

0.1.16 (September 13, 2021)

This release adds a new #[instrument(skip_all)] option to skip
recording all arguments to an instrumented function as fields.
Additionally, it adds support for recording arguments that are tracing
primitive types as typed values, rather than as fmt::Debug.

Added

  • add skip_all option to #[instrument] (#1548)
  • record primitive types as primitive values rather than as fmt::Debug
    (#1378)
  • added support for f64s as typed values (#1522)

Thanks to @Folyd and @jsgf for contributing to this release!

# 0.1.16 (September 13, 2021)

This release adds a new `#[instrument(skip_all)]` option to skip
recording *all* arguments to an instrumented function as fields.
Additionally, it adds support for recording arguments that are `tracing`
primitive types as typed values, rather than as `fmt::Debug`.

### Added

- add `skip_all` option to `#[instrument]` ([#1548])
- record primitive types as primitive values rather than as `fmt::Debug`
  ([#1378])
- added support for `f64`s as typed values ([#1522])

Thanks to @Folyd and @jsgf for contributing to this release!

[#1548]: #1548
[#1378]: #1378
[#1522]: #1524
@hawkw hawkw requested a review from a team as a code owner September 13, 2021 18:21
@hawkw hawkw merged commit 47036aa into v0.1.x Sep 13, 2021
@hawkw hawkw deleted the eliza/attributes-0.1.16 branch September 13, 2021 18:41
@CAD97
Copy link
Contributor

CAD97 commented Oct 3, 2021

I believe this (#1378) was a sneakily breaking change, in that instrumented argument captures of &str changed from matching field regexes of "value" to value.

@jsgf
Copy link
Contributor

jsgf commented Oct 4, 2021

Debug representations are explicitly not stable though, so it could change at any time anyway.

@hawkw
Copy link
Member Author

hawkw commented Oct 4, 2021

Yeah, I am not sure if I would consider the way fields are recorded to be part of the semver-versioned API. Sorry if that caused an inconvenience though!

@CAD97
Copy link
Contributor

CAD97 commented Oct 4, 2021

It's more that I've been dancing around causing an issue here with #1542 for filtering to string field values (the semantics of a filter [{field="value"}]), and the change just happened almost without me noticing 🙃

I agree that the new behavior is more correct, it's just interesting that I was dancing around this change and it just happened.

kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
# 0.1.16 (September 13, 2021)

This release adds a new `#[instrument(skip_all)]` option to skip
recording *all* arguments to an instrumented function as fields.
Additionally, it adds support for recording arguments that are `tracing`
primitive types as typed values, rather than as `fmt::Debug`.

### Added

- add `skip_all` option to `#[instrument]` ([tokio-rs#1548])
- record primitive types as primitive values rather than as `fmt::Debug`
  ([tokio-rs#1378])
- added support for `f64`s as typed values ([tokio-rs#1522])

Thanks to @Folyd and @jsgf for contributing to this release!

[tokio-rs#1548]: tokio-rs#1548
[tokio-rs#1378]: tokio-rs#1378
[tokio-rs#1522]: tokio-rs#1524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants