Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subscriber: remove Subscribe impls for Arcs #1649

Merged
merged 1 commit into from
Oct 19, 2021
Merged

subscriber: remove Subscribe impls for Arcs #1649

merged 1 commit into from
Oct 19, 2021

Commits on Oct 19, 2021

  1. subscriber: remove Subscribe impls for Arcs 

    Implementing `Subscribe` for `Arc`s, which are immutable, breaks the
ability to implement `Subscribe::on_layer` with a mutable reference.
This is necessary for per-layer filtering. See
#1576 (comment) for
details. Therefore, the `Layer` impls for `Arc`s should not be used.

In 0.3, we have the opportunity to remove these APIs. Therefore, this PR
removes them.
    @hawkw
    hawkw committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    72abf1a View commit details
    Browse the repository at this point in the history