Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscriber: update thread_local to 1.1.4 #1858

Merged
merged 1 commit into from Jan 24, 2022

Conversation

matze
Copy link
Contributor

@matze matze commented Jan 24, 2022

Fixes https://rustsec.org/advisories/RUSTSEC-2022-0006.

Motivation

cargo audit prevents us using tracing-subscriber at the moment. Upgrading thread_local to 1.1.4 would fix that.

Solution

Upgrade thread_local.

@matze matze requested review from davidbarsky, hawkw and a team as code owners January 24, 2022 15:42
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

For what it's worth, tracing-subscriber does not appear to use any of the APIs effected by the security advisory.

@hawkw hawkw enabled auto-merge (squash) January 24, 2022 18:12
@hawkw hawkw merged commit 7eb6005 into tokio-rs:master Jan 24, 2022
@matze matze deleted the fix-rustsec-2022-0006 branch January 24, 2022 18:40
@fu5ha
Copy link

fu5ha commented Jan 24, 2022

Any chance we could cut a 0.3.7 release with this in? Breaks our internal rustsec-deny CI atm and since fix is already in, would be nice to not have to patch it in the mean time.

@hawkw
Copy link
Member

hawkw commented Jan 25, 2022

yes, probably tomorrow.

hawkw pushed a commit that referenced this pull request Jan 25, 2022
Fixes https://rustsec.org/advisories/RUSTSEC-2022-0006.

## Motivation

`cargo audit` prevents us using `tracing-subscriber` at the moment.
Upgrading `thread_local` to 1.1.4 would fix that.

## Solution

Upgrade `thread_local`.
hawkw added a commit that referenced this pull request Jan 25, 2022
# 0.3.7 (Jan 25, 2022)

This release adds combinators for combining filters.

Additionally, this release also updates the `thread-local` crate to
v1.1.4, fixing warnings for the security advisory [RUSTSEC-2022-0006].
Note that previous versions of `tracing-subscriber` did not use any of
the `thread-local` crate's APIs effected by the vulnerability. However,
updating the version fixes warnings emitted by `cargo audit` and similar
tools.

### Added

- **filter**: Added combinators for combining filters ([#1578])

### Fixed

- **registry**: Updated `thread-local` to v1.1.4 ([#1858])

Thanks to new contributor @matze for contributing to this release!

[RUSTSEC-2022-0006]: https://rustsec.org/advisories/RUSTSEC-2022-0006
[#1578]: #1578
[#1858]: #1858
hawkw added a commit that referenced this pull request Jan 25, 2022
# 0.3.7 (Jan 25, 2022)

This release adds combinators for combining filters.

Additionally, this release also updates the `thread-local` crate to
v1.1.4, fixing warnings for the security advisory [RUSTSEC-2022-0006].
Note that previous versions of `tracing-subscriber` did not use any of
the `thread-local` crate's APIs effected by the vulnerability. However,
updating the version fixes warnings emitted by `cargo audit` and similar
tools.

### Added

- **filter**: Added combinators for combining filters ([#1578])

### Fixed

- **registry**: Updated `thread-local` to v1.1.4 ([#1858])

Thanks to new contributor @matze for contributing to this release!

[RUSTSEC-2022-0006]: https://rustsec.org/advisories/RUSTSEC-2022-0006
[#1578]: #1578
[#1858]: #1858
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants