Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscriber: add Filtered::filter_mut #1959

Merged
merged 1 commit into from
Mar 1, 2022

Commits on Mar 1, 2022

  1. subscriber: add Filtered::filter_mut method

     ## Motivation
    
    Changing the filter of a Filtered at runtime is currently only possible
    by replacing it with a new Filtered via the reload::Handle's reload method.
    This currently doesn't work (see
    tokio-rs#1629).
    
    While it would be desirable to just make that work, it would only be
    possible via a breaking change (according to Eliza).
    Making it possible to change the filter via the handle's modify method
    and mutating the inner filter is an easy workaround.
    tfreiberg-fastly committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    ddae0e9 View commit details
    Browse the repository at this point in the history