Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): use nu-ansi-term to replace ansi_term #2040

Closed
wants to merge 1 commit into from

Conversation

light4
Copy link

@light4 light4 commented Apr 1, 2022

Motivation

ansi_term last time update is over 2 years ago, use nutshell team forked nu-ansi-term instead

Solution

use nu-ansi-term

@light4 light4 requested review from hawkw, davidbarsky and a team as code owners April 1, 2022 14:45
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me!

@hawkw hawkw enabled auto-merge (squash) April 8, 2022 16:36
@hawkw
Copy link
Member

hawkw commented Apr 8, 2022

Looks like nu-ansi-term does not compile on tracing's current minimum-supported Rust version (MSRV) of Rust 1.49: https://github.com/tokio-rs/tracing/runs/5888551367?check_suite_focus=true

We'd need to bump the MSRV to at least 1.50 to get f64::clamp which stabilized in 1.50.

bors bot pushed a commit to bevyengine/bevy that referenced this pull request Aug 27, 2022
# Objective

- `ansi_term` has become unmaintained: ogham/rust-ansi-term#72
- This is now blocking our CI so we need to find a way around that.


## Solution

Temporary add `RUSTSEC-2021-0139` to ignore until tracing switches to a new crate: tokio-rs/tracing#2040

## Dependency tree
```
ansi_term v0.12.1
     └── tracing-subscriber v0.3.15
         ├── bevy_log v0.9.0-dev
         │   ├── bevy_asset v0.9.0-dev
         │   │   ├── bevy_animation v0.9.0-dev
         │   │   │   ├── bevy_gltf v0.9.0-dev
         │   │   │   │   └── bevy_internal v0.9.0-dev
         │   │   │   │       ├── bevy v0.9.0-dev
         │   │   │   │       └── bevy v0.9.0-dev (*)
         │   │   │   └── bevy_internal v0.9.0-dev (*)
         │   │   ├── bevy_audio v0.9.0-dev
         │   │   │   └── bevy_internal v0.9.0-dev (*)
         │   │   ├── bevy_core_pipeline v0.9.0-dev
         │   │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   │   ├── bevy_pbr v0.9.0-dev
         │   │   │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   │   │   └── bevy_internal v0.9.0-dev (*)
         │   │   │   ├── bevy_sprite v0.9.0-dev
         │   │   │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   │   │   ├── bevy_text v0.9.0-dev
         │   │   │   │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   │   │   │   └── bevy_ui v0.9.0-dev
         │   │   │   │   │       └── bevy_internal v0.9.0-dev (*)
         │   │   │   │   └── bevy_ui v0.9.0-dev (*)
         │   │   │   └── bevy_ui v0.9.0-dev (*)
         │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   ├── bevy_pbr v0.9.0-dev (*)
         │   │   ├── bevy_render v0.9.0-dev
         │   │   │   ├── bevy_core_pipeline v0.9.0-dev (*)
         │   │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   │   ├── bevy_pbr v0.9.0-dev (*)
         │   │   │   ├── bevy_scene v0.9.0-dev
         │   │   │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   │   │   └── bevy_internal v0.9.0-dev (*)
         │   │   │   ├── bevy_sprite v0.9.0-dev (*)
         │   │   │   ├── bevy_text v0.9.0-dev (*)
         │   │   │   └── bevy_ui v0.9.0-dev (*)
         │   │   ├── bevy_scene v0.9.0-dev (*)
         │   │   ├── bevy_sprite v0.9.0-dev (*)
         │   │   ├── bevy_text v0.9.0-dev (*)
         │   │   └── bevy_ui v0.9.0-dev (*)
         │   ├── bevy_diagnostic v0.9.0-dev
         │   │   ├── bevy_asset v0.9.0-dev (*)
         │   │   └── bevy_internal v0.9.0-dev (*)
         │   ├── bevy_gltf v0.9.0-dev (*)
         │   ├── bevy_internal v0.9.0-dev (*)
         │   ├── bevy_render v0.9.0-dev (*)
         │   ├── bevy_sprite v0.9.0-dev (*)
         │   └── bevy_ui v0.9.0-dev (*)
         └── tracing-wasm v0.2.1
             └── bevy_log v0.9.0-dev (*)
```
Suficio pushed a commit to Suficio/bevy that referenced this pull request Aug 29, 2022
# Objective

- `ansi_term` has become unmaintained: ogham/rust-ansi-term#72
- This is now blocking our CI so we need to find a way around that.


## Solution

Temporary add `RUSTSEC-2021-0139` to ignore until tracing switches to a new crate: tokio-rs/tracing#2040

## Dependency tree
```
ansi_term v0.12.1
     └── tracing-subscriber v0.3.15
         ├── bevy_log v0.9.0-dev
         │   ├── bevy_asset v0.9.0-dev
         │   │   ├── bevy_animation v0.9.0-dev
         │   │   │   ├── bevy_gltf v0.9.0-dev
         │   │   │   │   └── bevy_internal v0.9.0-dev
         │   │   │   │       ├── bevy v0.9.0-dev
         │   │   │   │       └── bevy v0.9.0-dev (*)
         │   │   │   └── bevy_internal v0.9.0-dev (*)
         │   │   ├── bevy_audio v0.9.0-dev
         │   │   │   └── bevy_internal v0.9.0-dev (*)
         │   │   ├── bevy_core_pipeline v0.9.0-dev
         │   │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   │   ├── bevy_pbr v0.9.0-dev
         │   │   │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   │   │   └── bevy_internal v0.9.0-dev (*)
         │   │   │   ├── bevy_sprite v0.9.0-dev
         │   │   │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   │   │   ├── bevy_text v0.9.0-dev
         │   │   │   │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   │   │   │   └── bevy_ui v0.9.0-dev
         │   │   │   │   │       └── bevy_internal v0.9.0-dev (*)
         │   │   │   │   └── bevy_ui v0.9.0-dev (*)
         │   │   │   └── bevy_ui v0.9.0-dev (*)
         │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   ├── bevy_pbr v0.9.0-dev (*)
         │   │   ├── bevy_render v0.9.0-dev
         │   │   │   ├── bevy_core_pipeline v0.9.0-dev (*)
         │   │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   │   ├── bevy_pbr v0.9.0-dev (*)
         │   │   │   ├── bevy_scene v0.9.0-dev
         │   │   │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   │   │   └── bevy_internal v0.9.0-dev (*)
         │   │   │   ├── bevy_sprite v0.9.0-dev (*)
         │   │   │   ├── bevy_text v0.9.0-dev (*)
         │   │   │   └── bevy_ui v0.9.0-dev (*)
         │   │   ├── bevy_scene v0.9.0-dev (*)
         │   │   ├── bevy_sprite v0.9.0-dev (*)
         │   │   ├── bevy_text v0.9.0-dev (*)
         │   │   └── bevy_ui v0.9.0-dev (*)
         │   ├── bevy_diagnostic v0.9.0-dev
         │   │   ├── bevy_asset v0.9.0-dev (*)
         │   │   └── bevy_internal v0.9.0-dev (*)
         │   ├── bevy_gltf v0.9.0-dev (*)
         │   ├── bevy_internal v0.9.0-dev (*)
         │   ├── bevy_render v0.9.0-dev (*)
         │   ├── bevy_sprite v0.9.0-dev (*)
         │   └── bevy_ui v0.9.0-dev (*)
         └── tracing-wasm v0.2.1
             └── bevy_log v0.9.0-dev (*)
```
@hawkw hawkw closed this in f09bc43 Aug 29, 2022
auto-merge was automatically disabled August 29, 2022 21:11

Pull request was closed

maccesch pushed a commit to Synphonyte/bevy that referenced this pull request Sep 28, 2022
# Objective

- `ansi_term` has become unmaintained: ogham/rust-ansi-term#72
- This is now blocking our CI so we need to find a way around that.


## Solution

Temporary add `RUSTSEC-2021-0139` to ignore until tracing switches to a new crate: tokio-rs/tracing#2040

## Dependency tree
```
ansi_term v0.12.1
     └── tracing-subscriber v0.3.15
         ├── bevy_log v0.9.0-dev
         │   ├── bevy_asset v0.9.0-dev
         │   │   ├── bevy_animation v0.9.0-dev
         │   │   │   ├── bevy_gltf v0.9.0-dev
         │   │   │   │   └── bevy_internal v0.9.0-dev
         │   │   │   │       ├── bevy v0.9.0-dev
         │   │   │   │       └── bevy v0.9.0-dev (*)
         │   │   │   └── bevy_internal v0.9.0-dev (*)
         │   │   ├── bevy_audio v0.9.0-dev
         │   │   │   └── bevy_internal v0.9.0-dev (*)
         │   │   ├── bevy_core_pipeline v0.9.0-dev
         │   │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   │   ├── bevy_pbr v0.9.0-dev
         │   │   │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   │   │   └── bevy_internal v0.9.0-dev (*)
         │   │   │   ├── bevy_sprite v0.9.0-dev
         │   │   │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   │   │   ├── bevy_text v0.9.0-dev
         │   │   │   │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   │   │   │   └── bevy_ui v0.9.0-dev
         │   │   │   │   │       └── bevy_internal v0.9.0-dev (*)
         │   │   │   │   └── bevy_ui v0.9.0-dev (*)
         │   │   │   └── bevy_ui v0.9.0-dev (*)
         │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   ├── bevy_pbr v0.9.0-dev (*)
         │   │   ├── bevy_render v0.9.0-dev
         │   │   │   ├── bevy_core_pipeline v0.9.0-dev (*)
         │   │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   │   ├── bevy_pbr v0.9.0-dev (*)
         │   │   │   ├── bevy_scene v0.9.0-dev
         │   │   │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   │   │   └── bevy_internal v0.9.0-dev (*)
         │   │   │   ├── bevy_sprite v0.9.0-dev (*)
         │   │   │   ├── bevy_text v0.9.0-dev (*)
         │   │   │   └── bevy_ui v0.9.0-dev (*)
         │   │   ├── bevy_scene v0.9.0-dev (*)
         │   │   ├── bevy_sprite v0.9.0-dev (*)
         │   │   ├── bevy_text v0.9.0-dev (*)
         │   │   └── bevy_ui v0.9.0-dev (*)
         │   ├── bevy_diagnostic v0.9.0-dev
         │   │   ├── bevy_asset v0.9.0-dev (*)
         │   │   └── bevy_internal v0.9.0-dev (*)
         │   ├── bevy_gltf v0.9.0-dev (*)
         │   ├── bevy_internal v0.9.0-dev (*)
         │   ├── bevy_render v0.9.0-dev (*)
         │   ├── bevy_sprite v0.9.0-dev (*)
         │   └── bevy_ui v0.9.0-dev (*)
         └── tracing-wasm v0.2.1
             └── bevy_log v0.9.0-dev (*)
```
hawkw pushed a commit that referenced this pull request Oct 6, 2022
This increases the MSRV of `tracing-subscriber` to 1.50+.

## Motivation

[ansi_term] last time update is over 2 years ago, use
nushell team forked [nu-ansi-term] instead

## Solution

Use [nu-ansi-term].

Closes #2040

[nu-ansi-term]: https://github.com/nushell/nu-ansi-term
[ansi_term]: https://github.com/ogham/rust-ansi-term
hawkw pushed a commit that referenced this pull request Oct 6, 2022
This increases the MSRV of `tracing-subscriber` to 1.50+.

## Motivation

[ansi_term] last time update is over 2 years ago, use
nushell team forked [nu-ansi-term] instead

## Solution

Use [nu-ansi-term].

Closes #2040

[nu-ansi-term]: https://github.com/nushell/nu-ansi-term
[ansi_term]: https://github.com/ogham/rust-ansi-term
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
# Objective

- `ansi_term` has become unmaintained: ogham/rust-ansi-term#72
- This is now blocking our CI so we need to find a way around that.


## Solution

Temporary add `RUSTSEC-2021-0139` to ignore until tracing switches to a new crate: tokio-rs/tracing#2040

## Dependency tree
```
ansi_term v0.12.1
     └── tracing-subscriber v0.3.15
         ├── bevy_log v0.9.0-dev
         │   ├── bevy_asset v0.9.0-dev
         │   │   ├── bevy_animation v0.9.0-dev
         │   │   │   ├── bevy_gltf v0.9.0-dev
         │   │   │   │   └── bevy_internal v0.9.0-dev
         │   │   │   │       ├── bevy v0.9.0-dev
         │   │   │   │       └── bevy v0.9.0-dev (*)
         │   │   │   └── bevy_internal v0.9.0-dev (*)
         │   │   ├── bevy_audio v0.9.0-dev
         │   │   │   └── bevy_internal v0.9.0-dev (*)
         │   │   ├── bevy_core_pipeline v0.9.0-dev
         │   │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   │   ├── bevy_pbr v0.9.0-dev
         │   │   │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   │   │   └── bevy_internal v0.9.0-dev (*)
         │   │   │   ├── bevy_sprite v0.9.0-dev
         │   │   │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   │   │   ├── bevy_text v0.9.0-dev
         │   │   │   │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   │   │   │   └── bevy_ui v0.9.0-dev
         │   │   │   │   │       └── bevy_internal v0.9.0-dev (*)
         │   │   │   │   └── bevy_ui v0.9.0-dev (*)
         │   │   │   └── bevy_ui v0.9.0-dev (*)
         │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   ├── bevy_pbr v0.9.0-dev (*)
         │   │   ├── bevy_render v0.9.0-dev
         │   │   │   ├── bevy_core_pipeline v0.9.0-dev (*)
         │   │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   │   ├── bevy_pbr v0.9.0-dev (*)
         │   │   │   ├── bevy_scene v0.9.0-dev
         │   │   │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   │   │   └── bevy_internal v0.9.0-dev (*)
         │   │   │   ├── bevy_sprite v0.9.0-dev (*)
         │   │   │   ├── bevy_text v0.9.0-dev (*)
         │   │   │   └── bevy_ui v0.9.0-dev (*)
         │   │   ├── bevy_scene v0.9.0-dev (*)
         │   │   ├── bevy_sprite v0.9.0-dev (*)
         │   │   ├── bevy_text v0.9.0-dev (*)
         │   │   └── bevy_ui v0.9.0-dev (*)
         │   ├── bevy_diagnostic v0.9.0-dev
         │   │   ├── bevy_asset v0.9.0-dev (*)
         │   │   └── bevy_internal v0.9.0-dev (*)
         │   ├── bevy_gltf v0.9.0-dev (*)
         │   ├── bevy_internal v0.9.0-dev (*)
         │   ├── bevy_render v0.9.0-dev (*)
         │   ├── bevy_sprite v0.9.0-dev (*)
         │   └── bevy_ui v0.9.0-dev (*)
         └── tracing-wasm v0.2.1
             └── bevy_log v0.9.0-dev (*)
```
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

- `ansi_term` has become unmaintained: ogham/rust-ansi-term#72
- This is now blocking our CI so we need to find a way around that.


## Solution

Temporary add `RUSTSEC-2021-0139` to ignore until tracing switches to a new crate: tokio-rs/tracing#2040

## Dependency tree
```
ansi_term v0.12.1
     └── tracing-subscriber v0.3.15
         ├── bevy_log v0.9.0-dev
         │   ├── bevy_asset v0.9.0-dev
         │   │   ├── bevy_animation v0.9.0-dev
         │   │   │   ├── bevy_gltf v0.9.0-dev
         │   │   │   │   └── bevy_internal v0.9.0-dev
         │   │   │   │       ├── bevy v0.9.0-dev
         │   │   │   │       └── bevy v0.9.0-dev (*)
         │   │   │   └── bevy_internal v0.9.0-dev (*)
         │   │   ├── bevy_audio v0.9.0-dev
         │   │   │   └── bevy_internal v0.9.0-dev (*)
         │   │   ├── bevy_core_pipeline v0.9.0-dev
         │   │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   │   ├── bevy_pbr v0.9.0-dev
         │   │   │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   │   │   └── bevy_internal v0.9.0-dev (*)
         │   │   │   ├── bevy_sprite v0.9.0-dev
         │   │   │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   │   │   ├── bevy_text v0.9.0-dev
         │   │   │   │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   │   │   │   └── bevy_ui v0.9.0-dev
         │   │   │   │   │       └── bevy_internal v0.9.0-dev (*)
         │   │   │   │   └── bevy_ui v0.9.0-dev (*)
         │   │   │   └── bevy_ui v0.9.0-dev (*)
         │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   ├── bevy_pbr v0.9.0-dev (*)
         │   │   ├── bevy_render v0.9.0-dev
         │   │   │   ├── bevy_core_pipeline v0.9.0-dev (*)
         │   │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   │   ├── bevy_internal v0.9.0-dev (*)
         │   │   │   ├── bevy_pbr v0.9.0-dev (*)
         │   │   │   ├── bevy_scene v0.9.0-dev
         │   │   │   │   ├── bevy_gltf v0.9.0-dev (*)
         │   │   │   │   └── bevy_internal v0.9.0-dev (*)
         │   │   │   ├── bevy_sprite v0.9.0-dev (*)
         │   │   │   ├── bevy_text v0.9.0-dev (*)
         │   │   │   └── bevy_ui v0.9.0-dev (*)
         │   │   ├── bevy_scene v0.9.0-dev (*)
         │   │   ├── bevy_sprite v0.9.0-dev (*)
         │   │   ├── bevy_text v0.9.0-dev (*)
         │   │   └── bevy_ui v0.9.0-dev (*)
         │   ├── bevy_diagnostic v0.9.0-dev
         │   │   ├── bevy_asset v0.9.0-dev (*)
         │   │   └── bevy_internal v0.9.0-dev (*)
         │   ├── bevy_gltf v0.9.0-dev (*)
         │   ├── bevy_internal v0.9.0-dev (*)
         │   ├── bevy_render v0.9.0-dev (*)
         │   ├── bevy_sprite v0.9.0-dev (*)
         │   └── bevy_ui v0.9.0-dev (*)
         └── tracing-wasm v0.2.1
             └── bevy_log v0.9.0-dev (*)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants