Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracing: fix issues compiling for WASM/other <=32-bit platforms #2060

Merged
merged 3 commits into from
Apr 8, 2022
Merged

tracing: fix issues compiling for WASM/other <=32-bit platforms #2060

merged 3 commits into from
Apr 8, 2022

Commits on Apr 8, 2022

  1. kick ci

    @hawkw
    hawkw committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    ebf74f2 View commit details
    Browse the repository at this point in the history

  2. tracing: fix warning on <=32-bit platforms 

    This changes the "unregistered" interest state from `0xDEADFACED`
to`0xDEAD`, which should fit in a `usize` even on 16-bit platforms. The
actual value of this thing doesn't matter at all, it just has to be "not
0, 1, or 2", and it's good for it to be something weird to make it more
obvious in the event of stuff going wrong.

This should fix a warning being emitted when building for wasm (and
other <=32-bit platforms) because the previous literal would be
truncated.
    @hawkw
    hawkw committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    22af7c7 View commit details
    Browse the repository at this point in the history

  3. tracing: skip macros_redefined_core tests on wasm 

    Apparently the wasm-bindgen test messes with these somehow, so just skip
them.
    @hawkw
    hawkw committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    a8ff5a2 View commit details
    Browse the repository at this point in the history