pass through max_level_hint in reload::Layer #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
1 task
hawkw
approved these changes
Jul 1, 2022
Comment on lines
+150
to
+152
| assert_eq!(LevelFilter::current(), LevelFilter::INFO); | ||
| handle.reload(Filter::Two).expect("should reload"); | ||
| assert_eq!(LevelFilter::current(), LevelFilter::DEBUG); |
There was a problem hiding this comment.
slight pref for having a separate test for max level hinting, but 🤷♀️ i don't care that much
kmahar
pushed a commit
to kmahar/tracing
that referenced
this pull request
Jul 7, 2022
## Motivation When using a `reload` layer, the fast-path current level check doesn't work, as the `max_level_hint` is just `None`, which `rebuild_interest` interprets as `TRACE` ## Solution Pass through to the underlying layer/filter. On poisons, when already panicking, just return `None`
hawkw
pushed a commit
that referenced
this pull request
Jul 20, 2022
## Motivation When using a `reload` layer, the fast-path current level check doesn't work, as the `max_level_hint` is just `None`, which `rebuild_interest` interprets as `TRACE` ## Solution Pass through to the underlying layer/filter. On poisons, when already panicking, just return `None`
hawkw
pushed a commit
that referenced
this pull request
Jul 20, 2022
## Motivation When using a `reload` layer, the fast-path current level check doesn't work, as the `max_level_hint` is just `None`, which `rebuild_interest` interprets as `TRACE` ## Solution Pass through to the underlying layer/filter. On poisons, when already panicking, just return `None`
hawkw
pushed a commit
that referenced
this pull request
Jul 20, 2022
## Motivation When using a `reload` layer, the fast-path current level check doesn't work, as the `max_level_hint` is just `None`, which `rebuild_interest` interprets as `TRACE` ## Solution Pass through to the underlying layer/filter. On poisons, when already panicking, just return `None`
hawkw
added a commit
that referenced
this pull request
Jul 20, 2022
# 0.3.15 (Jul 20, 2022) This release fixes a bug where the `reload` layer would fail to pass through `max_level_hint` to the underlying layer, potentially breaking filtering. ### Fixed - **reload**: pass through `max_level_hint` to the inner `Layer` ([#2204]) Thanks to @guswynn for contributing to this release! [#2204]: #2204
hawkw
added a commit
that referenced
this pull request
Jul 20, 2022
# 0.3.15 (Jul 20, 2022) This release fixes a bug where the `reload` layer would fail to pass through `max_level_hint` to the underlying layer, potentially breaking filtering. ### Fixed - **reload**: pass through `max_level_hint` to the inner `Layer` ([#2204]) Thanks to @guswynn for contributing to this release! [#2204]: #2204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using a
reloadlayer, the fast-path current level check doesn't work, as themax_level_hintis justNone, whichrebuild_interestinterprets asTRACESolution
Pass through to the underlying layer/filter. On poisons, when already panicking, just return
None