subscriber: allow to customize Registry with sharded_slab Config. #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can also port to v0.1.x branch, if v0.2 is not planned soon. |
|
I'll review this in a minute, but please keep this branch pointed at 0.2. |
Adds CollectionBuilder with_slab_config::<S>() func to this end. This e.g. allows to use tracing in environment with >= 4k threads. c.f. tokio-rs#1485
arssher
force-pushed
the
subscriber-custom-slab-cfg
branch
from
48aec0a
to
cfcc6b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
CollectionBuilderwith_slab_config::<S>()func to this end. This e.g. allows to use tracing in environment with >= 4k threads.c.f. #1485
Motivation
Allow to use tracing with more than 4k threads and generally customize underlying
sharded_slab.Solution
Add one more type parameter to relevent structures and provide
with_slab_configfor easy configuration.