Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): warning styles in html-in-header #2449

Merged
merged 2 commits into from Feb 8, 2023
Merged

fix(doc): warning styles in html-in-header #2449

merged 2 commits into from Feb 8, 2023

Conversation

rwakulszowa
Copy link
Contributor

Motivation

The documentation under https://tracing.rs/tracing/ is missing CSS styles.
Fixes #2444

Solution

Used the --html-in-header rustdoc flag instead of --extend-css. Converted the css file into an html file.

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix, this looks good to me!

@hawkw hawkw enabled auto-merge (squash) February 8, 2023 18:15
@hawkw hawkw disabled auto-merge February 8, 2023 18:24
@hawkw hawkw merged commit 2ace0b5 into tokio-rs:master Feb 8, 2023
@rwakulszowa rwakulszowa deleted the fix-docs-style branch February 9, 2023 07:57
davidbarsky pushed a commit that referenced this pull request Sep 27, 2023
The documentation under https://tracing.rs/tracing/ is missing CSS
styles. Fixes #2444

Used the `--html-in-header` rustdoc flag instead of `--extend-css`.
Converted the css file into an html file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation - warning header styles not loaded
2 participants