rustc: remove deprecated private_in_public lint
#2886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `private_in_public` rustc lint is now deprecated and throws a warning on each `cargo check`. According to the rfc [0] this lint is being substituted by three other ones: `private_interfaces`, `private_bounds` and `unnameable_types`. `unnameable_types` is not yet stabilized [1], so it will throw a warning, but we will be ready when it is :) [0]: https://rust-lang.github.io/rfcs/2145-type-privacy.html [1]: rust-lang/rust#120144
|
We could add Ideally with a TODO comment to get rid of it once the last lint is stabilized. |
|
We could... but I am not sure—this could lead to us forgetting about it :/ |
|
This has already been fixed on Regarding adding tracing/.github/workflows/CI.yml Line 69 in 908cc43 cargo check/cargo clippy when adding attributes referencing lists that don't exist as part of a change, but CI won't fail when a lint is removed/deprecated. That seems like a good compromise between not breaking CI on new Rust versions and warning contributors that a lint isn't valid. What do you think?
|
|
Yes, I agree! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
private_in_publicrustc lint is now deprecated and throws a warning on eachcargo check. According to the rfc 1 this lint is being substituted by three other ones:private_interfaces,private_boundsandunnameable_types.unnameable_typesis not yet stabilized 2, so it will throw a warning, but we will be ready when it is :)Footnotes
https://rust-lang.github.io/rfcs/2145-type-privacy.html ↩
https://github.com/rust-lang/rust/pull/120144 ↩