log: LogTracer
checks if events are enabled
#70
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the
LogTracer
adapter intokio-trace-log
does not checkif an event translated from a
log
record would be enabled by thecurrent dispatcher, and always dispatches the event. This means that
the
tokio-trace
subscribers never have the opportunity to filter thatevent.
Solution
This branch changes the
LogTracer
to callenabled
on the currentdispatcher before creating an event. Unfortunately, we can't do this in
the
log::Log::enabled
impl forLogTracer
, since thelog::Metadata
lacks all the information required to create a
tokio_trace::Metadata
.There are some potential improvements that we can make as follow-ups: in
particular, the
LogTracer
can keep its own cache of log records andInterests
, similar to the callsite cache, to avoid re-evaluatingfilters. Additionally, if we add an
Event::new
(seetokio-rs/tokio#1149), we can eliminate a redundant thread-local storage
access. I'll open issues for these changes as follow-ups.
Signed-off-by: Eliza Weisman eliza@buoyant.io