Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare to release tracing-core 0.1.16 #968

Merged
merged 4 commits into from
Sep 8, 2020

Conversation

davidbarsky
Copy link
Member

Preparing a release containing changes #966.

@davidbarsky davidbarsky requested a review from a team September 7, 2020 18:29
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can publish a new tracing until #954 is resolved. 0.1.20 had to be yanked due to inadvertently breaking existing code. I'm happy to merge this with a tracing version bump as well, but I won't publish a new tracing release until we figure out that issue.

I think that if we go ahead and ship a new core, most users should still be able to pick up the fix. We might want to publish a new tracing-subscriber, with an updated tracing-core dep, as well, since it was a tracing-subscriber API that broke as a result of the LevelFilter change?

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we ought to do a tracing-subscriber release as well, but we can do that in another PR.

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of changelog nits

tracing-core/CHANGELOG.md Outdated Show resolved Hide resolved
tracing-core/CHANGELOG.md Outdated Show resolved Hide resolved
davidbarsky and others added 2 commits September 7, 2020 16:13
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hawkw hawkw changed the title chore: Prepare release to tracing-core and tracing chore: prepare to release tracing-core 0.1.16 Sep 8, 2020
tracing-core/CHANGELOG.md Outdated Show resolved Hide resolved
@hawkw hawkw merged commit 29ccdf9 into master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants