Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: replace marray by mutate.array #1930

Merged
merged 5 commits into from
Nov 6, 2023
Merged

lib: replace marray by mutate.array #1930

merged 5 commits into from
Nov 6, 2023

Conversation

michaellilltokiwa
Copy link
Member

No description provided.

maxteufel
maxteufel reviewed Aug 31, 2023
View reviewed changes
lib/Sequence.fz Outdated Show resolved Hide resolved
@michaellilltokiwa michaellilltokiwa marked this pull request as ready for review October 20, 2023 16:26
fridis
fridis requested changes Nov 3, 2023
View reviewed changes
Copy link
Member

@fridis fridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the very late review, I thought this would cause more problems.
Very nice to get rid of marray.
Just a few comments on syntax that can be improved now due to #1950 having been merged.

lib/io/buffered/reader.fz Outdated Show resolved Hide resolved
lib/container/hash_map.fz Outdated Show resolved Hide resolved
@fridis fridis merged commit dab062c into tokiwa-software:main Nov 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridis fridis fridis approved these changes

@maxteufel maxteufel Awaiting requested review from maxteufel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michaellilltokiwa @maxteufel @fridis