parser: disallow line break after -> in function return type, fix #1945
#1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1945 This is an somewhat ugly special handling but the best solution that I could find so far to avoid the ambiguity between a feature declaration with a function result type and a call with a lambda argument. Now, it is no longer legal to write declarations such as f () -> i32 := ()->42 one must use either f (() -> i32 ) := ()->42 or f () -> i32 := ()->42 while a call f ()-> x := 42 can not be written as f ()->x:=42 This patch adds a positive and a negative regression test for #1945.
|
Merging this since I need it for examples in my TyDe talk. Please review anyway. |
maxteufel
reviewed
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an somewhat ugly special handling but the best solution that I could find so far to avoid the ambiguity between a feature declaration with a function result type and a call with a lambda argument.
Now, it is no longer legal to write declarations such as
one must use either
or
while a call
can not be written as
This patch adds a positive and a negative regression test for #1945.