Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

be/jvm: implement primitive type to Java Object fuzion.java intrinsics #2001

Merged
merged 3 commits into from
Sep 26, 2023
Merged

be/jvm: implement primitive type to Java Object fuzion.java intrinsics #2001

merged 3 commits into from
Sep 26, 2023

Conversation

maxteufel
Copy link
Collaborator

No description provided.

fridis
fridis requested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@fridis fridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just would like to understand better why the bad field is needed and maybe improve that.

lib/fuzion/sys/internal_array.fz Outdated Show resolved Hide resolved
maxteufel
maxteufel commented Sep 21, 2023
View reviewed changes
src/dev/flang/be/jvm/Intrinsix.java Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, the code can probably be deduplicated here. I will do this in a separate patch once this has been merged.

@maxteufel maxteufel mentioned this pull request Sep 25, 2023
Merged
fridis
fridis approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@fridis fridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, apart form the mark_used calls that could be cleaned up separately.

src/dev/flang/me/MiddleEnd.java Outdated Show resolved Hide resolved
@maxteufel maxteufel merged commit 84d61f1 into tokiwa-software:main Sep 26, 2023
4 checks passed
@maxteufel maxteufel deleted the be-jvm-fuzion-java-primitive-type-to-java-object-intrinsics branch September 26, 2023 11:07
@maxteufel maxteufel mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridis fridis fridis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxteufel @fridis