Support for constant arrays of numeric element types. #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
fridis
force-pushed
the
const_arrays
branch
from
1ed24bd
to
1997773
Compare
maxteufel
requested changes
Sep 26, 2023
…he heap.
The problem was that a call of the form
f =>
[1,2,3].as_list
will pass a ref to the array to `array.as_list`, which will create a Cons cell
that contains that ref. Since that Cons cell with be returned as the list result
of `f`, we have a dangling reference.
Before array consts, this was solved since the array was instanciated via a call
and the call result was heap cloned explicitly.
In a later step, I would like to see all const arrays stored globally and
allocated only once such that all the cloning would no longer be a problem.
As for heap cloning for call results in the C backend: This is done way too, the
plan is to find a common solution for this in the JVM and C backend, so no need
to worry right now.
…ay elements The problem was that the comparison of `SysArrays` did not take the element values into account, such that joining the `SysArray`s of `[123]` with `[]` could result in the `SysArray` for `[]`, whose element values was `null`, i.e., `void` resulting in DFA to stop analysis when accessing the elements of `[123]`. This patch fixes `SysArray.compareTo` to compare `_elements`. Additionally, it adds some infrastucture that may help in the future to extract the element values from the data array of a constant array. This patch also add element values for the result of `fuzion.sys.fileio.mmap` which was missing and worked only by chance.
…, length The original code using `FUIR.clazzField` with constant indices is very brittle because it is sensitive to changes in the order of declared fields.
…t16_t[], float[], etc.
Constants of non-primitive types, i.e., arrays and constant strings, are now created globally in fzC_universe during class initialization. Duplicate constants are detected and removed.
…tant arrays Replaced `forEach` by explicit lookups.
Also added comment.
…Java_Ref This got lost somewhere in the pulls and merges.
fridis
force-pushed
the
const_arrays
branch
from
090b588
to
b9b58a0
Compare
|
I have added commits for the requested changes plus two additional commits:
|
This is required, e.g., for constants `i16 0` that are no longer a call to `i16`, but constants now.
I intentionally removed these during the merge due to your comment saying to remove them as they're probably not necessary. |
Do not trust me! |
I have tested both variants before making the pull request, which is why I asked you here. |
|
I actually just noticed a lot more JVM tests were failing with messages referencing With |
maxteufel
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the size of the generated code, in particular for the JVM backend that previously was not able to create bytecode for the tables used for ryu float to string conversion code.
Now, constant arrays are serialized into an array of bytes that is then processed by the backend to produce code that creates the array.