Skip to content

Commit

Permalink
Checking in changes prior to tagging of version 3.06.
Browse files Browse the repository at this point in the history
Changelog diff is:

diff --git Changes Changes
index 6f4f7f1..33cae18 100644
--- Changes
+++ Changes
@@ -2,6 +2,37 @@ Revision history for Perl module Furl

 {{$NEXT}}

+3.06 2015-02-09T23:05:09Z
+
+    commit 8a77869
+    Author: Jari Salmela <bissei@users.noreply.github.com>
+    Date:   Fri Feb 6 08:36:55 2015 +0200
+
+        Update HTTP.pm
+
+        fix for keep-alive as zmmail proposed.
+        "In line 526 of Furl/HTTP.pm, FURL checks the HTTP response headers it gets from the server. It will read the C
+    onnection from the response header there, and compare the header value with the string keep-alive. The problem is t
+    hat this does not take into account a different case of the response header. Some HTTP server returns a header valu
+    e of Keep-Alive (mind the caps), so FURL does not recognize it properly.
+
+        I think the following change to Furl/HTTP.pm is more robust.
+
+        if ($connection_header eq 'keep-alive') {
+        if (lc($connection_header) eq 'keep-alive') {"
+
+    commit 91ebdf8
+    Author: Kazuho Oku <kazuhooku@gmail.com>
+    Date:   Wed Dec 24 16:26:07 2014 +0900
+
+        fix incorrect regex used for testing the response line (amends #80)
+
+    commit 65d0bc1
+    Author: HIROSE Masaaki <hirose31@gmail.com>
+    Date:   Wed Dec 24 13:49:43 2014 +0900
+
+        Check only status code when connect SSL over proxy
+
 3.05 2014-09-24T03:47:02Z

     - Validate content-length before processing.
  • Loading branch information
tokuhirom committed Feb 9, 2015
1 parent 59e1ca9 commit 7a44027
Show file tree
Hide file tree
Showing 4 changed files with 39 additions and 6 deletions.
31 changes: 31 additions & 0 deletions Changes
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,37 @@ Revision history for Perl module Furl

{{$NEXT}}

3.06 2015-02-09T23:05:09Z

commit 8a7786905c101eeab9db1d7baa8c4ec2076f9514
Author: Jari Salmela <bissei@users.noreply.github.com>
Date: Fri Feb 6 08:36:55 2015 +0200

Update HTTP.pm

fix for keep-alive as zmmail proposed.
"In line 526 of Furl/HTTP.pm, FURL checks the HTTP response headers it gets from the server. It will read the C
onnection from the response header there, and compare the header value with the string keep-alive. The problem is t
hat this does not take into account a different case of the response header. Some HTTP server returns a header valu
e of Keep-Alive (mind the caps), so FURL does not recognize it properly.

I think the following change to Furl/HTTP.pm is more robust.

if ($connection_header eq 'keep-alive') {
if (lc($connection_header) eq 'keep-alive') {"

commit 91ebdf86693c5bfbda497df167977813e2ad75aa
Author: Kazuho Oku <kazuhooku@gmail.com>
Date: Wed Dec 24 16:26:07 2014 +0900

fix incorrect regex used for testing the response line (amends #80)

commit 65d0bc170a6344ebd24e0726a44260f3771fda0b
Author: HIROSE Masaaki <hirose31@gmail.com>
Date: Wed Dec 24 13:49:43 2014 +0900

Check only status code when connect SSL over proxy

3.05 2014-09-24T03:47:02Z

- Validate content-length before processing.
Expand Down
10 changes: 6 additions & 4 deletions META.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"Tokuhiro Matsuno <tokuhirom@gmail.com>"
],
"dynamic_config" : 0,
"generated_by" : "Minilla/v2.1.1, CPAN::Meta::Converter version 2.141520",
"generated_by" : "Minilla/v2.2.0, CPAN::Meta::Converter version 2.141520",
"license" : [
"perl_5"
],
Expand Down Expand Up @@ -118,7 +118,7 @@
"web" : "https://github.com/tokuhirom/Furl"
}
},
"version" : "3.05",
"version" : "3.06",
"x_contributors" : [
"Keiji, Yoshimi <walf443@gmail.com>",
"Fuji, Goro <gfuji@cpan.org>",
Expand All @@ -132,9 +132,11 @@
"xaicron <xaicron@gmail.com>",
"Syohei YOSHIDA <syohex@gmail.com>",
"Neil Bowers <neil@bowers.com>",
"Kazuho Oku <kazuhooku@gmail.com>",
"Toshio Ito <debug.ito@gmail.com>",
"bayashi <bayashi@cpan.org>",
"Masahiro Nagano <kazeburo@gmail.com>"
"Masahiro Nagano <kazeburo@gmail.com>",
"HIROSE Masaaki <hirose31@gmail.com>",
"Kazuho Oku <kazuhooku@gmail.com>",
"Jari Salmela <bissei@users.noreply.github.com>"
]
}
2 changes: 1 addition & 1 deletion lib/Furl.pm
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use Furl::HTTP;
use Furl::Request;
use Furl::Response;
use Carp ();
our $VERSION = '3.05';
our $VERSION = '3.06';

use 5.008001;

Expand Down
2 changes: 1 addition & 1 deletion lib/Furl/HTTP.pm
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use warnings;
use base qw/Exporter/;
use 5.008001;

our $VERSION = '3.05';
our $VERSION = '3.06';

use Carp ();
use Furl::ConnectionCache;
Expand Down

0 comments on commit 7a44027

Please sign in to comment.