IO::Socket::IP is required not only on test time #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazuho
added a commit
that referenced
this pull request
Apr 7, 2015
IO::Socket::IP is required not only on test time
kazuho
added a commit
that referenced
this pull request
Apr 7, 2015
Changelog diff is:
diff --git a/Changes b/Changes
index b31475c..d96882d 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,9 @@ Revision history for Perl module Test::TCP
{{$NEXT}}
+2.11 2015-04-07T00:07:25Z
+ - declare IO::Socket::IP as dependency #36
+
2.10 2015-04-06T19:23:43Z
- ensure the test object is DESTROYed when Net::EmptyPort::empty_port exits https://rt.cpan.org/Public/Bug/Display.html?id=103299
|
Thank you for noticing the issue! Merged and shipped as 2.11. |
tokuhirom
added a commit
that referenced
this pull request
May 18, 2015
Changelog diff is:
diff --git Changes Changes
index d96882d..2c5eb49 100644
--- Changes
+++ Changes
@@ -2,6 +2,11 @@ Revision history for Perl module Test::TCP
{{$NEXT}}
+2.12 2015-05-18T08:14:30Z
+
+ - Fixed spelling mistake
+ (Reported by gregor herrmann)
+
2.11 2015-04-07T00:07:25Z
- declare IO::Socket::IP as dependency #36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EmptyPort.pm uses IO::Socket::IP so it is not a test-only dependency.
Unless one have IO::Socket::IP installed already this means that dist simply fails to compile despite installing all declared dependencies (when test-only deps were not installed, i.e. when "cpanm --notest" was used)