fix: Avoid infinite loading on saving error

tolgee · Jun 9, 2022 · c26d94c · c26d94c
1 parent d285c01
commit c26d94c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/webapp/src/views/projects/translations/cell/ControlsEditor.tsx b/webapp/src/views/projects/translations/cell/ControlsEditor.tsx
@@ -1,4 +1,4 @@
-import React, { useEffect, useState } from 'react';
+import React from 'react';
 import { T } from '@tolgee/react';
 import { Button, styled } from '@mui/material';
 import { CameraAlt } from '@mui/icons-material';
@@ -52,13 +52,6 @@ export const ControlsEditor: React.FC<ControlsProps> = ({
 
   const isEditLoading = useTranslationsSelector((c) => c.isEditLoading);
 
-  const [isLoading, setIsLoading] = useState(isEditLoading);
-  useEffect(() => {
-    if (isEditLoading && !isLoading) {
-      setIsLoading(true);
-    }
-  }, [isEditLoading]);
-
   return (
     <>
       <StyledLeftPart>
@@ -76,7 +69,7 @@ export const ControlsEditor: React.FC<ControlsProps> = ({
           color="primary"
           variant="contained"
           size="small"
-          loading={isLoading}
+          loading={isEditLoading}
           data-cy="translations-cell-save-button"
         >
           <T>translations_cell_save</T>

diff --git a/webapp/src/views/projects/translations/context/services/useTagsService.tsx b/webapp/src/views/projects/translations/context/services/useTagsService.tsx
@@ -1,4 +1,4 @@
-import { useTranslate, T } from '@tolgee/react';
+import { T } from '@tolgee/react';
 import { useQueryClient } from 'react-query';
 import { container } from 'tsyringe';
 
@@ -21,7 +21,6 @@ export const useTagsService = ({ translations }: Props) => {
   const putTag = usePutTag();
   const deleteTag = useDeleteTag();
   const project = useProject();
-  const t = useTranslate();
 
   const removeTag = (data: RemoveTag) =>
     deleteTag