feat: Add telemetry collection #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanCizmar
force-pushed
the
jancizmar/add-telemetry-collection
branch
from
5b543d3
to
b09d28c
Compare
JanCizmar
changed the title
cyyynthia
reviewed
Jul 20, 2023
backend/data/src/main/kotlin/io/tolgee/component/reporting/BusinessEventPublisher.kt
Outdated
Show resolved
Hide resolved
cyyynthia
reviewed
Jul 20, 2023
backend/data/src/main/kotlin/io/tolgee/configuration/tolgee/TelemetryProperties.kt
Show resolved
Hide resolved
|
Its in the billing repoOn 20. 7. 2023, at 18:43, Cynthia ***@***.***> wrote:
@cyyynthia commented on this pull request.
In backend/data/src/main/kotlin/io/tolgee/configuration/tolgee/TelemetryProperties.kt:
+ @DocProperty(hidden = true)
+ var server: String = "https://app.tolgee.io"
I must be blind, because I double checked and I don't see it being used besides in the TelemetryService... The tests do modify whether it is enabled and the reporting time in ms, but I couldn't find an instance of server being modified/altered 🤔
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Oooooh alright, that makes sense. Got it 👍🏻 |
cyyynthia
approved these changes
Jul 20, 2023
TolgeeMachine
pushed a commit
that referenced
this pull request
Jul 20, 2023
# [3.23.0](v3.22.0...v3.23.0) (2023-07-20) ### Features * Add telemetry collection ([#1814](#1814)) ([40d130d](40d130d))
|
🎉 This PR is included in version 3.23.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.