Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include initializers in gem files #109

Merged
merged 1 commit into from
May 4, 2015
Merged

Conversation

lime
Copy link
Contributor

@lime lime commented May 4, 2015

Our gemspec is pretty specific about what files to include in the built gem, causing the will_paginate initializer to be left out, in turn breaking compatibility with will_paginate.

Fixes #108.

@lime
Copy link
Contributor Author

lime commented May 4, 2015

Also: since the initializer was introduced in version 1.8.0, maybe the maintainers could release a 1.8.1 with this change backported..?

thomasdarde added a commit that referenced this pull request May 4, 2015
Include initializers in gem files
@thomasdarde thomasdarde merged commit 2f7819c into tolk:master May 4, 2015
@thomasdarde
Copy link
Member

Thanks for the fix !

@lime lime deleted the gem-initializers branch May 5, 2015 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoMethodError: undefined method `paginates_per' withoud Kaminari (v1.8.0)
2 participants