Add rust toolchain and retris package #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusCDE
changed the title
|
@LinusCDE No oxide configuration? |
Add oxide info to retris
|
Thanks for your work on this @LinusCDE. Will review as soon as possible. |
matteodelabre
requested changes
Sep 4, 2020
package/retris/package
Outdated
| license=MIT | ||
|
|
||
| origin=https://github.com/LinusCDE/retris.git | ||
| revision=0.5.3-1 |
There was a problem hiding this comment.
For security, I’d suggest putting the whole SHA-1 ID of the targeted commit here. If someone takes control of your repository, it’s easy for them to make the 0.5.3-1 tag points to different, potentially malicious code. This is harder to do with the commit ID, although attacks against SHA-1 are not unknown of.
There was a problem hiding this comment.
That's a very good idea. I even changed the tag sometime later to the latest commit, because I accidentally committed my custom ipkg. So yeah. They are very changeable which shouldn't be allowed here, indeed.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
see the commits for more info.