package/wikipedia #309
Closed
package/wikipedia #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial wikipedia package. * Fix missing fields * rewrite the EABI
|
I would recommend adding an icon. Everything seems to work great though (aside from the issues/enhancements I've already opened on your repo)! |
Eeems
approved these changes
Mar 11, 2021
|
I suggest someone test on rM2 since ddvk/remarkable2-framebuffer#17 has been a long-standing issue. my understanding is dps fixed that in dps/remarkable-wikipedia@ad039ff a few days ago, but it should still be verified by someone with an rM2. |
|
I can probably give it a shot tonight. Edit: Even if links turn out to be broken, that's no reason to keep the package out of testing. |
dps/remarkable-wikipedia#12 Known issue |
|
Closing in favor of #311 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.1.0-1 of remarkable-wikipedia for toltec