Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koreader: Add service unit #441

Merged
merged 5 commits into from
Sep 26, 2021
Merged

Conversation

matteodelabre
Copy link
Member

This PR adds a systemd service unit for starting KOReader at boot time (see #437). If KOReader fails to start, it falls back to Xochitl. It also updates the Xochitl service definition to alias to launcher.service; this is to prevent situations where both KOReader and Xochitl are enabled to start at boot time (see #438).

This PR adds a systemd service unit for starting KOReader at boot time (see #437). If KOReader fails to start, it falls back to Xochitl. It also updates the Xochitl service definition to alias to `launcher.service`; this is to prevent situations where both KOReader and Xochitl are enabled to start at boot time (see #438).
@matteodelabre matteodelabre added the packages Add or improve packages of the repository label Sep 25, 2021
Copy link
Member

@Eeems Eeems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package should also have install/uninstall scripts handling letting the user know about the service, and properly stopping/disabling it on uninstall.

@matteodelabre
Copy link
Member Author

Good point, thanks! I added that.

Eeems
Eeems previously approved these changes Sep 26, 2021
Copy link
Member

@Eeems Eeems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but I haven't tested.

@matteodelabre
Copy link
Member Author

Thanks for approving the PR—I had to push a new commit to fix the formatting, which auto-dismissed your review.

Changes look good, but I haven't tested.

I’ve performed the following tests on my rM2: checked that enabling the service does start KOReader at boot, that it’s not possible to enable both KOReader and Xochitl at the same time, and that the configure() script suggests the appropriate command for enabling KOReader, depending on whether Xochitl is enabled.

I don’t think there is any rM1-specific things in this PR, so it should work fine on rM1.

@Eeems
Copy link
Member

Eeems commented Sep 26, 2021

It looks like while you can't enable both tarnish and koreader with this, you can start them both at the same time. Is that expected?

@matteodelabre
Copy link
Member Author

matteodelabre commented Sep 26, 2021

Yes, this is unfortunate, but I didn’t find a clean way to prevent this. This is not a regression from the Conflicts=-based approach though, since even conflicting services can be manually started at the same time.

@matteodelabre matteodelabre merged commit 5a63c37 into testing Sep 26, 2021
@matteodelabre matteodelabre deleted the package/koreader/add-service-unit branch September 26, 2021 23:35
matteodelabre added a commit that referenced this pull request Oct 5, 2021
This is a small update that mainly improves support for system update 2.9.

Updated packages:

* ddvk-hacks - 24.04-1 (#439)
* display, rm2fb-client - 1:0.0.7-2 (#446)
* draft - 0.2.0-21 (#446)
* koreader - 2021.09-2 (#441)
* erode, fret, oxide, rot, tarnish, decay, corrupt, anxiety - 2.2.2-1 (#444)
* xochitl - 0.0.0-8 (#441)
matteodelabre added a commit that referenced this pull request Oct 15, 2021
This is a small update that mainly improves support for system update 2.9.

Updated packages:

* ddvk-hacks - 24.04-1 (#439)
* display, rm2fb-client - 1:0.0.7-2 (#446)
* draft - 0.2.0-21 (#446)
* koreader - 2021.09-2 (#441)
* erode, fret, oxide, rot, tarnish, decay, corrupt, anxiety - 2.2.2-1 (#444)
* xochitl - 0.0.0-8 (#441)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Add or improve packages of the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include a Toltec-compatible 'koreader.service' unit with installation
2 participants