-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koreader: Add service unit #441
Conversation
This PR adds a systemd service unit for starting KOReader at boot time (see #437). If KOReader fails to start, it falls back to Xochitl. It also updates the Xochitl service definition to alias to `launcher.service`; this is to prevent situations where both KOReader and Xochitl are enabled to start at boot time (see #438).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package should also have install/uninstall scripts handling letting the user know about the service, and properly stopping/disabling it on uninstall.
Good point, thanks! I added that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, but I haven't tested.
Thanks for approving the PR—I had to push a new commit to fix the formatting, which auto-dismissed your review.
I’ve performed the following tests on my rM2: checked that enabling the service does start KOReader at boot, that it’s not possible to enable both KOReader and Xochitl at the same time, and that the configure() script suggests the appropriate command for enabling KOReader, depending on whether Xochitl is enabled. I don’t think there is any rM1-specific things in this PR, so it should work fine on rM1. |
It looks like while you can't enable both tarnish and koreader with this, you can start them both at the same time. Is that expected? |
Yes, this is unfortunate, but I didn’t find a clean way to prevent this. This is not a regression from the |
This is a small update that mainly improves support for system update 2.9. Updated packages: * ddvk-hacks - 24.04-1 (#439) * display, rm2fb-client - 1:0.0.7-2 (#446) * draft - 0.2.0-21 (#446) * koreader - 2021.09-2 (#441) * erode, fret, oxide, rot, tarnish, decay, corrupt, anxiety - 2.2.2-1 (#444) * xochitl - 0.0.0-8 (#441)
This is a small update that mainly improves support for system update 2.9. Updated packages: * ddvk-hacks - 24.04-1 (#439) * display, rm2fb-client - 1:0.0.7-2 (#446) * draft - 0.2.0-21 (#446) * koreader - 2021.09-2 (#441) * erode, fret, oxide, rot, tarnish, decay, corrupt, anxiety - 2.2.2-1 (#444) * xochitl - 0.0.0-8 (#441)
This PR adds a systemd service unit for starting KOReader at boot time (see #437). If KOReader fails to start, it falls back to Xochitl. It also updates the Xochitl service definition to alias to
launcher.service
; this is to prevent situations where both KOReader and Xochitl are enabled to start at boot time (see #438).