Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the process for moving packages from testing to stable #81

Merged
merged 11 commits into from Oct 14, 2020

Conversation

matteodelabre
Copy link
Member

This creates the docs/branches.md document which explains what the two release branches are, which one users should choose, and how the transition of packages from one branch to another is handled.

It also updates docs/package.md to add related information about the maintainer field.

This implements the proposal in #20, and closes #20 as a consequence.

@matteodelabre matteodelabre added the documentation Improvements or additions to the documentation and to workflows label Sep 28, 2020
@matteodelabre matteodelabre changed the title Implement the process proposed in #20 Implement the process for moving packages from testing to stable Sep 28, 2020
@matteodelabre
Copy link
Member Author

This is mostly RFC, I tried to implement what we discussed, but please point out any problems in the documents.

@Eeems
Copy link
Member

Eeems commented Sep 28, 2020

@matteodelabre If this is a RFC right now, might as well convert it to a draft until we decide it's ready.

@matteodelabre matteodelabre marked this pull request as draft September 28, 2020 21:53
@matteodelabre

This comment has been minimized.

@Eeems

This comment has been minimized.

@Eeems
Copy link
Member

Eeems commented Sep 28, 2020

Just reviewed the content and it looks good to me. It would be nice to set up automation as part of this PR to create the merge window PR on a schedule as well.

@raisjn
Copy link
Contributor

raisjn commented Sep 28, 2020

what's the process of becoming a maintainer and are the expectations of maintainers outlined somewhere?

@matteodelabre
Copy link
Member Author

Just reviewed the content and it looks good to me. It would be nice to set up automation as part of this PR to create the merge window PR on a schedule as well.

Should this automatically-created PR contain all of the package/ directory from the testing branch? I don’t think we can create empty PRs.

@matteodelabre
Copy link
Member Author

what's the process of becoming a maintainer and are the expectations of maintainers outlined somewhere?

The process by which a maintainer is assigned to a package is described in this PR. As the document says, they are expected to review PRs regarding the packages they maintain. The process for adding a new repository maintainer is not outlined here, and I’d say it’s out of the scope of this PR.

@Eeems
Copy link
Member

Eeems commented Sep 29, 2020

Just reviewed the content and it looks good to me. It would be nice to set up automation as part of this PR to create the merge window PR on a schedule as well.

Should this automatically-created PR contain all of the package/ directory from the testing branch? I don’t think we can create empty PRs.

I'd say no, likely we should just have a dummy file that we bump a timestamp in or something.

@matteodelabre
Copy link
Member Author

It turns out we can actually create empty PRs, by adding an empty commit to a branch (with git commit --allow-empty).

raisjn
raisjn previously approved these changes Oct 3, 2020
@matteodelabre matteodelabre added the merge Weekly merge of the testing branch into the stable branch label Oct 4, 2020
@matteodelabre matteodelabre mentioned this pull request Oct 11, 2020
5 tasks
docs/branches.md Outdated Show resolved Hide resolved
docs/branches.md Outdated Show resolved Hide resolved
@matteodelabre matteodelabre linked an issue Oct 12, 2020 that may be closed by this pull request
5 tasks
@matteodelabre matteodelabre marked this pull request as ready for review October 12, 2020 19:00
@matteodelabre
Copy link
Member Author

I think it’s best if we move forward with stabilizing the actual merge process then implement automation in a future PR.

raisjn
raisjn previously approved these changes Oct 13, 2020
Copy link
Contributor

@raisjn raisjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. thanks for the update around bugfixes!

@matteodelabre
Copy link
Member Author

Just needed to fix a link and add instructions for switching to testing before merging.

@matteodelabre
Copy link
Member Author

If you still agree with this change set, could you re-approve the PR @raisjnn? Your review was dismissed since I changed the link in the README and added instructions to switch to testing. Thanks!

Copy link
Contributor

@raisjn raisjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the note about bug fixes!

@matteodelabre matteodelabre merged commit 4c37bb6 into testing Oct 14, 2020
@matteodelabre matteodelabre deleted the patch-specify-stable-testing branch October 14, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to the documentation and to workflows merge Weekly merge of the testing branch into the stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define a process for moving packages from testing to stable Add usage documentation
3 participants