-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependencies "contain code that will be rejected by a future version of Rust" #271
Comments
Thanks for the report @MightyPork - I tend to agree that switching to a maintained provider of I'd accept a PR to do that, otherwise I will look at it myself when I have time. |
This is, unfortunately, more trouble than it initially seemed.
The spanner in the works comes from Rouille can't be the only place these new deprecation warnings are showing up so I'll see if there is any information elsewhere about what the suggested migration plan is. |
Is it possible to make |
Yes, but doing so is a breaking change and requires a Regardless you'd still be caught out by the hit on |
I don't have either of these in my dependency tree:
|
…cies (`buf_redux`, `multipart`). See: tomaka/rouille#271
What is the path forward here? There is now a somewhat recent RUSTSEC advisory for |
How are Hyper and traitobject relevant here? They don't seem to be dependencies of Rouille. |
I'm getting this warning when built using latest rustc:
warning: the following packages contain code that will be rejected by a future version of Rust: buf_redux v0.8.4, multipart v0.18.0
multipart
is abandoned andbuf_redux
is its abandoned dependency. The cleanest fix would be to switch to something else providing multipart encoding.I made local forks of the affected crates and fixed it, also upgraded them to 2021 edition.
The fix was trivial, mostly just adding dyn and removing some semicolons in macros.
Here's the patches needed to do that:
buf_redux:
5514df91edd41543afa8b51c51fd3824b66e8b67.diff.txt
multipart:
f56611df6a528ab3141c1f9a047401f2140fb69a.diff.txt
The text was updated successfully, but these errors were encountered: