Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in 3.3.0: accidental creation of global.signal, gets caught in strict UTs #429

Closed
oliverlockwood opened this issue Dec 11, 2023 · 0 comments · Fixed by #430
Closed

Comments

@oliverlockwood
Copy link
Contributor

Reproduction scenario:

  • .mocharc.json containing "check-leaks": true,
  • a mocha UT which makes a Needle request
  • needle version 3.3.0
  • the test starts failing with Error: global leak(s) detected: 'signal'

Investigation and debugging proved the issue was a rogue semicolon that should have been a colon.
Perhaps an argument in favour of separate var declarations instead of a block of them?
In any case, it's a 1-character fix, which I will raise as a PR very shortly.

This bug was not in Needle 3.2.0.

oliverlockwood added a commit to oliverlockwood/needle that referenced this issue Dec 11, 2023
tomas added a commit that referenced this issue Dec 11, 2023
…-signal-creation

#429: fix accidental creation of 'signal' global variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant