Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#429: fix accidental creation of 'signal' global variable #430

Merged
merged 1 commit into from
Dec 11, 2023
Merged

#429: fix accidental creation of 'signal' global variable #430

merged 1 commit into from
Dec 11, 2023

Conversation

oliverlockwood
Copy link
Contributor

Fixes #429.

@tomas tomas merged commit 6b14ce4 into tomas:master Dec 11, 2023
@tomas
Copy link
Owner

tomas commented Dec 11, 2023

Thanks @oliverlockwood !

@oliverlockwood
Copy link
Contributor Author

You're very welcome.

@oliverlockwood oliverlockwood deleted the 429-fix-accidental-global-signal-creation branch December 21, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in 3.3.0: accidental creation of global.signal, gets caught in strict UTs
2 participants
@oliverlockwood @tomas