Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dbt): Support for dbt-core >= 1.1 #58

Merged
merged 3 commits into from May 5, 2022
Merged

feat(dbt): Support for dbt-core >= 1.1 #58

merged 3 commits into from May 5, 2022

Conversation

tomasfarias
Copy link
Owner

Closes #54

Just realized that logging is still a big bugged: the dbt loggers are
producing multiple lines of output that are essentially the same, but
one of them is the debug output. This is caused by both the file
logger and the stdout logger being fired off. We tried to clear the
handlers from one of them in
operators.dbt.BaseDbtOperator.override_dbt_logging but this is not
working.

Due to this being fairly low priority, it will be fixed in a later commit.
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #58 (3ce4c3c) into master (a6e0fe4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files           8        8           
  Lines         917      923    +6     
=======================================
+ Hits          905      911    +6     
  Misses         12       12           
Flag Coverage Δ
unittests 98.69% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
airflow_dbt_python/hooks/dbt.py 98.55% <100.00%> (+0.01%) ⬆️
airflow_dbt_python/operators/dbt.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e0fe4...3ce4c3c. Read the comment docs.

@tomasfarias tomasfarias marked this pull request as ready for review May 5, 2022 23:14
@tomasfarias tomasfarias merged commit 6f24aa0 into master May 5, 2022
@tomasfarias tomasfarias deleted the dbt-core-1.1 branch May 5, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for dbt-core 1.1.0
1 participant