Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistent data storage #4

Closed
tomaspietravallo opened this issue Aug 14, 2021 · 0 comments
Closed

Persistent data storage #4

tomaspietravallo opened this issue Aug 14, 2021 · 0 comments
Assignees
@tomaspietravallo
Labels
on-the-roadmap Will be actively worked on in the future
Milestone
v1.0.0

Comments

@tomaspietravallo
Copy link
Owner

Add an interface to save/fetch Persistent data.

As of now, the idea is to use the setDebounce function + some wrapper to make the process of saving/loading data easier, while preventing any bad code from overloading the API.

Note: Potential bug:

Previously, the Persistence module had a bug which caused a promise to never(/30s+) resolve, depending on the implementation, this would slow down or completely prevent an experience from running.

This was patched by using Promise.race, and was later addressed by the Spark/IG dev team, but it would be nice to be prepared for any similar bugs.

My guess is that the PersistenceModule is more reliant on the device + isn't used as much by creators, so the issue might have passed internal tests without anyone noticing. (This is pure speculation and I have no basis).

In any case, making use of Promise.race seems like the better option
@tomaspietravallo tomaspietravallo added the on-the-roadmap Will be actively worked on in the future label Aug 14, 2021
@tomaspietravallo tomaspietravallo self-assigned this Aug 14, 2021
@tomaspietravallo tomaspietravallo added this to the v1.0.0 milestone Aug 15, 2021
tomaspietravallo added a commit that referenced this issue Aug 19, 2021
@tomaspietravallo
createState, Persistent data storage. #4
38b7fbb 
`createState` might be modified in the future. Last big feature to be released before closing #1.

`createState` might be used in the future in combination with the Multipeer API to facilitate the creation of Video Calling/ARVC experiences

Tests using an improved Persistence mock module need to be added (#8)
@tomaspietravallo tomaspietravallo changed the title Persistent data storage Persistant data storage Aug 20, 2021
@tomaspietravallo tomaspietravallo changed the title Persistant data storage Persistent data storage Aug 20, 2021
tomaspietravallo added a commit that referenced this issue Aug 20, 2021
@tomaspietravallo
createState, Persistant data storage. #4
cb1e49e 
`createState` might be modified in the future. Last big feature to be released before closing #1.

`createState` might be used in the future in combination with the Multipeer API to facilitate the creation of Video Calling/ARVC experiences

Tests using an improved Persistence mock module need to be added (#8)
@tomaspietravallo tomaspietravallo mentioned this issue Aug 20, 2021
Merged
tomaspietravallo added a commit that referenced this issue Aug 20, 2021
@tomaspietravallo
Merge pull request #1 from tomaspietravallo/beta
938d18d 
Some of the main changes include:

* First beta release, initial contents

* Fix onLoad/onFrame accessors

* screenToWorld2D & minor Vector changes. #5

* Camera & focalDistance

* Improvements and extra functionality

* Dynamic snapshots. Addresses #7

* Improvements + major changes to World.run

* Fix pause on DEV mode

* Runs TimedEvents in order

* addToSnapshot & removeFromSnapshot

* Introduce Jest tests & CI #2

* Tests and bug fixed

* createState, Persistant data storage. #4
tomaspietravallo added a commit that referenced this issue Aug 20, 2021
@tomaspietravallo
Force World load State readiness & name change. #4
72d5b8d
tomaspietravallo added a commit that referenced this issue Aug 21, 2021
@tomaspietravallo
50%+ code coverage 🥳(#2)
e04253f 
* Improved Persistence mock (#8)
* Fixed Reactive functional values
* Coded `setTimeoutWithSnapshot`
* + `state.test.ts`
* `World.run` tests
* Closes #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomaspietravallo tomaspietravallo

Labels
on-the-roadmap Will be actively worked on in the future
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@tomaspietravallo