-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple ECDSA support #359
Simple ECDSA support #359
Conversation
This pull request introduces 5 alerts and fixes 1 when merging 2087e80 into 401712c - view on LGTM.com new alerts:
fixed alerts:
|
ebacb8e
to
1fd2cc1
Compare
This pull request fixes 1 alert when merging 1fd2cc1 into 401712c - view on LGTM.com fixed alerts:
|
1fd2cc1
to
2b6c6da
Compare
This pull request fixes 1 alert when merging 2b6c6da into 401712c - view on LGTM.com fixed alerts:
|
no support for client authentication with ECDSA for now
2b6c6da
to
0199b2d
Compare
This pull request fixes 1 alert when merging 0199b2d into 401712c - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, 5 of 5 files at r2, 4 of 4 files at r3, 1 of 1 files at r4, 4 of 4 files at r5, 3 of 3 files at r6, 9 of 9 files at r7.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tomato42)
tlslite/utils/python_key.py, line 112 at r5 (raw file):
def _parse_ecc_ssleay(data): """ Parse binary structure of the old SSLeay file fromat used by OpenSSL.
s/fromat/format/
allow the parsePEM to parse both RSA and ECDSA key files
support for ECDSA authentication without client certificates
0199b2d
to
d44800d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 13 of 26 files reviewed, 1 unresolved discussion (waiting on @ansasaki)
tlslite/utils/python_key.py, line 112 at r5 (raw file):
Previously, ansasaki (Anderson Sasaki) wrote…
s/fromat/format/
Done.
This pull request fixes 1 alert when merging d44800d into 401712c - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 13 of 13 files at r8, 3 of 3 files at r9, 9 of 9 files at r10.
Reviewable status:complete! all files reviewed, all discussions resolved
To be honest, in this review I couldn't check all the changes (for example the hardcoded keys, cipher suites allowed for each TLS version, etc.). I'm relying on the results of the added tests, which seems to cover the changes. |
that's the idea: the tests should show that the code works :) the proper test coverage will come with tlsfuzzer/tlsfuzzer#543 and related issues thanks! |
Support for ECDSA authentication from server side
(first part of the full ECDSA support, #52, reworking of #196 to make review easier)
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)