Faster handshake #419
Merged
Faster handshake #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
tomato42
force-pushed
the
faster-prf
branch
from
806e592
to
e32c64d
Compare
This comment has been minimized.
This comment has been minimized.
tomato42
force-pushed
the
faster-prf
branch
from
e32c64d
to
cd6a64c
Compare
This comment has been minimized.
This comment has been minimized.
tomato42
force-pushed
the
faster-prf
branch
from
cd6a64c
to
71f7e24
Compare
This comment has been minimized.
This comment has been minimized.
every time we call a HMAC_SHA256 it needs to create a new instance and calculate the i_key and o_key, even if the key used is the same use one instance of the HMAC and just copy state also use multiple update calls, don't concatenate inputs
tomato42
force-pushed
the
faster-prf
branch
from
71f7e24
to
7df73e3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tomato42
force-pushed
the
faster-prf
branch
from
a01ddfb
to
7098222
Compare
|
This pull request fixes 2 alerts when merging 7098222 into e8da6cf - view on LGTM.com fixed alerts:
|
Jakuje
previously approved these changes
Sep 25, 2020
tlslite/utils/compat.py
Outdated
| else: | ||
| def compat26Str(x): return x | ||
|
|
||
| def remove_whitespace(text): | ||
| """Removes all whitespace from passed in string""" | ||
| return re.sub(r"\s+", "", text, flags=re.UNICODE) | ||
|
|
||
| def bit_length(val): | ||
| """Return number of bytes necessary to represent an integer.""" |
| def skip_bytes(self, length): | ||
| """Move the internal pointer ahead length bytes.""" | ||
| if self.index + length > len(self.bytes): | ||
| raise DecodeError("Read past end of buffer") |
There was a problem hiding this comment.
Maybe different exception message like "Skipped past the end of buffer"?
There was a problem hiding this comment.
this method is used only to get to the point we want to read, so while "skipped past..." would make more sense on the level of the Parser class, for the classes higher up the stack I think "Read past end of buffer" is more understandable
tomato42
force-pushed
the
faster-prf
branch
from
7098222
to
a005589
Compare
|
This pull request fixes 2 alerts when merging a005589 into e8da6cf - view on LGTM.com fixed alerts:
|
|
thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimise methods and functions used heavily in a handshake.
Speeds it up by about 25%
fixes #356
This change is