Add support for interlacing arguments and explicit option ending #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the ability to parse interlaced arguments and options.
For example, the following:
GBCli foo -o bar --print-settings
will now be parsed as:
Arguments:
foo
Options:
output = bar
print-settings
without needing to place all arguments after options.
|
Pull request looks good - great work! I found an issue with It though: it breaks option groups - see my comment at 7fdf6d5 commit. Quick one line change fixes that, but I didn't test it in combination with interlacing arguments and explicit option ending... Please update and test if it still works with newly added stuff, then I'll be glad to merge! It's really something that should've been implemented with unit tests, but so far I didn't bother writing them - sorry for that... |
|
Thanks! |
tomaz
added a commit
that referenced
this pull request
Nov 27, 2014
Add support for interlacing arguments and explicit option ending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #9.