Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding markerWithLabel With Async Google Map #595

Closed
abhayjeetgupta opened this issue Sep 7, 2017 · 5 comments
Closed

Adding markerWithLabel With Async Google Map #595

abhayjeetgupta opened this issue Sep 7, 2017 · 5 comments
Labels
feature request: PRs welcomed identified bug: submit PRs?
Projects
v9.0.0: Prepare for React@^16

Comments

@abhayjeetgupta
Copy link

How can I add MarkerWithLabel With Async Google Map ?
@tomchentw
Copy link
Owner

Will need some rewrite on the MarkerWithLabel component……

@d46
Copy link
Contributor

d46 commented Sep 14, 2017

@abhayjeetgupta I handled this issue using with external google loader for temporarily not with AsyncLoader.

After call back of google-maps library i set up marker-with-label

@tomchentw I need this implementation too. If there will be not a PR for this, I could do it in a couple of days.

@tomchentw
Copy link
Owner

@RGFnaGFuIEd1bmF5 please do a PR. Also note that 8.0.0 is released with a brand new architecture. It should be a lot easier to create a component now.

@d46
Copy link
Contributor

d46 commented Oct 10, 2017

#657

tomchentw pushed a commit that referenced this issue Oct 16, 2017
@tomchentw
feat(addons/MarkerWithLabel): separate from Marker
73275da 
* Closes #595
* Closes #604
* Ref #657
@tomchentw
Copy link
Owner

Released v9.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request: PRs welcomed identified bug: submit PRs?
Projects
v9.0.0: Prepare for React@^16
v9.0.0
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomchentw @d46 @abhayjeetgupta