Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jank in large infoWindows #449

Closed
wants to merge 2 commits into from

Conversation

ztanner
Copy link
Contributor

@ztanner ztanner commented Mar 17, 2017

This fixes an issue that several people (including myself) were having (#444 #408). Large info windows would flicker underneath the infoWindow because an div was added to the infoWindow content before actually rendering the infowindow content. This renders the child component to the div before giving it to the infoWindow.

I'm not sure if this is the best solution but it worked for my purposes. Open to any other suggestions.

@rayozerets
Copy link

Hi, ztanner!
How need fixes file "LIB/InfoWindow.js"?

@stereobooster
Copy link

stereobooster commented Apr 1, 2017

This is not helping. Content should be rendered before window showed. Will give a try too

tomchentw pushed a commit that referenced this pull request Apr 20, 2017
* Original commit: 81adb63
* Original author: @ztanner
* Closes #449, #444, #408
@tomchentw tomchentw closed this in 54ffccc Apr 20, 2017
@tomchentw
Copy link
Owner

Released 6.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants